You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/09/12 07:20:29 UTC
[GitHub] [camel-k] tadayosi opened a new issue, #3628: Enable CLI completion for integration, kit, kamelet names
tadayosi opened a new issue, #3628:
URL: https://github.com/apache/camel-k/issues/3628
Currently there's no completion after for example:
```
kamel get [TAB]
kamel kit get [TAB]
kamel kamelet delete [TAB]
```
Ideally they should show the integration/kit/kamelet names already deployed on the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
gansheer commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1348594734
The `kamel kit delete` completion already exists : the command only shows non-platform kits. Is this behavior something that should evolve to all kits (even the platform ones) for delete ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1345705329
This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1351340079
> The `kamel kit delete` completion already exists : the command only shows non-platform kits. Is this behavior something that should evolve to all kits (even the platform ones) for the `kamel kit delete` or should it stay like this? I don't know why this exclusion of platform kits is done.
>
> https://github.com/apache/camel-k/blob/322e43c365305b510c129f24372688890db8c607/pkg/cmd/completion_bash.go#L160-L170
>
> @lburgazzoli @astefanutti do you have any information ?
I think the general idea was that kits of type `platform` are managed by the operator, as opposed to kits created by users, and should be "hidden" away from users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1350567354
Yeah, as @gansheer outlined it doesn't seem to make much sense to provide auto completion for `kamel bind` as it accepts a variety of inputs. We can focus on the other commands for implementing auto completion and ignore `kamel bind` for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
gansheer commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1351401902
> I think the general idea was that kits of type `platform` are managed by the operator, as opposed to kits created by users, and should be "hidden" away from users.
I get the idea, but since the command allows the deletion platform kits without any specific flag I wonder if it is a good idea to have a completion that does not retrieve the same results than the allowed values for the command.
I fear it might just confuse the user. I am really tempted to remove the platform exclusion filter but am unsure about the end user real life use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi closed issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
tadayosi closed issue #3628: Enable CLI completion for integration, kit, kamelet names
URL: https://github.com/apache/camel-k/issues/3628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
gansheer commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1352666197
Hi,
> Hi,
>
> Actually, no, you cannot delete platform kits with `kamel kit delete`. They are protected from cli. There's even no flag to force performing it. So sometimes I tend to need to do this to clean up platform kits: `kubectl delete ik ...`
You are absolutely right, I just realized I used the `kubectl` command most of the time. The completion command is good for `kamel kit delete`.
Thank you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1350425220
> What is expected on then kamel bind autocomplete ?
The `kamel bind` can accept any kamelet or generic Camel URI. I'd say that the autocompletion could look up on Kamelets that are available in the namespace where we're willing to run the KameletBinding. We cannot do much more than that, as the user can provide any other URI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
gansheer commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1348896623
@tadayosi @squakez
What is expected on then `kamel bind` autocomplete ? While we could default to the custom resources `kamelets.camel.apache.org`, the command description "Bind Kubernetes resources, such as Kamelets, in an integration flow. Endpoints are expected in the format \"[[apigroup/]version:]kind:[namespace/]name\" or plain Camel URIs." clearly indicates more possibilities.
What I understand from "Kubernetes resources" looks like a lot of possible kubernetes objects (more than we could predict) to have an autocomplete on it but I might be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1352598315
Hi,
> I get the idea, but since the command allows the deletion platform kits without any specific flag I wonder if it is a good idea to have a completion that does not retrieve the same results than the allowed values for the command.
Actually, no, you cannot delete platform kits with `kamel kit delete`. There's even no flag to force performing it. So sometimes I tend to need to do this to clean up platform kits: `kubectl delete ik ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3628: Enable CLI completion for integration, kit, kamelet names
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3628:
URL: https://github.com/apache/camel-k/issues/3628#issuecomment-1243358033
Do you think is this okey for "good first issue" label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org