You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/28 17:40:33 UTC
[GitHub] [pulsar] yuruguo opened a new pull request, #18252: [Authorization] Modify authorization to update topic's properties
yuruguo opened a new pull request, #18252:
URL: https://github.com/apache/pulsar/pull/18252
### Motivation
Current users with production permission can change the properties of topic, which will cause the properties of topic to become uncontrollable due to arbitrary changes. In fact, only tenant administrator and super user can change them.
### Modifications
- Modify `TopicOperation.PRODUCE` to `TopicOperation.UPDATE_METADATA` in internalUpdatePropertiesAsync method
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18252:
URL: https://github.com/apache/pulsar/pull/18252#issuecomment-1296523035
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18252?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18252](https://codecov.io/gh/apache/pulsar/pull/18252?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6e9f99) into [master](https://codecov.io/gh/apache/pulsar/commit/3f5acfea0d2cc1cdacc5a0d44bf6ede517276349?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f5acfe) will **increase** coverage by `31.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18252?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18252 +/- ##
=============================================
+ Coverage 38.91% 70.79% +31.87%
+ Complexity 8283 438 -7845
=============================================
Files 683 26 -657
Lines 67290 2246 -65044
Branches 7218 245 -6973
=============================================
- Hits 26187 1590 -24597
+ Misses 38095 483 -37612
+ Partials 3008 173 -2835
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.79% <ø> (+31.87%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18252?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pulsar/broker/admin/impl/PersistentTopicsBase.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1BlcnNpc3RlbnRUb3BpY3NCYXNlLmphdmE=) | | |
| [...t/NonPersistentDispatcherSingleActiveConsumer.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudERpc3BhdGNoZXJTaW5nbGVBY3RpdmVDb25zdW1lci5qYXZh) | | |
| [.../pulsar/broker/rest/RestMessagePublishContext.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXN0L1Jlc3RNZXNzYWdlUHVibGlzaENvbnRleHQuamF2YQ==) | | |
| [...org/apache/pulsar/broker/admin/v1/BrokerStats.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJTdGF0cy5qYXZh) | | |
| [...oker/service/nonpersistent/NonPersistentTopic.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFRvcGljLmphdmE=) | | |
| [...ulsar/broker/service/PulsarChannelInitializer.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1bHNhckNoYW5uZWxJbml0aWFsaXplci5qYXZh) | | |
| [...roker/admin/impl/OffloaderObjectsScannerUtils.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL09mZmxvYWRlck9iamVjdHNTY2FubmVyVXRpbHMuamF2YQ==) | | |
| [...ersistentStickyKeyDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN0aWNreUtleURpc3BhdGNoZXJNdWx0aXBsZUNvbnN1bWVycy5qYXZh) | | |
| [...roker/stats/metrics/ManagedLedgerCacheMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJDYWNoZU1ldHJpY3MuamF2YQ==) | | |
| [...r/client/impl/schema/reader/JacksonJsonReader.java](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL3NjaGVtYS9yZWFkZXIvSmFja3Nvbkpzb25SZWFkZXIuamF2YQ==) | | |
| ... and [647 more](https://codecov.io/gh/apache/pulsar/pull/18252/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #18252:
URL: https://github.com/apache/pulsar/pull/18252#issuecomment-1296722873
> > @yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.
>
> First, add this feature in #17238, which will release in the 2.12 version, no breaking changes.
You are right @nodece, PTAL @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #18252:
URL: https://github.com/apache/pulsar/pull/18252#issuecomment-1296497025
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #18252:
URL: https://github.com/apache/pulsar/pull/18252#issuecomment-1296518761
@yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece merged pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
nodece merged PR #18252:
URL: https://github.com/apache/pulsar/pull/18252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #18252: [fix][broker] Modify authorization to update topic's properties
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #18252:
URL: https://github.com/apache/pulsar/pull/18252#issuecomment-1296542832
> @yuruguo It's a behavior change. It's better to have a discussion under the dev mailing list to make sure everyone can know what will be changed.
First, add this feature in https://github.com/apache/pulsar/pull/17238, which will release in the 2.12 version, no breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org