You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2016/05/29 04:34:46 UTC
hbase git commit: HBASE-15912. REST module has 2 extent warnings in
findbugs.
Repository: hbase
Updated Branches:
refs/heads/master f4470af95 -> 4abc602e3
HBASE-15912. REST module has 2 extent warnings in findbugs.
ScannerResource defines a variable params the is never used.
TableResource catches Exception when IOException is thrown.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4abc602e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4abc602e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4abc602e
Branch: refs/heads/master
Commit: 4abc602e3b3e7ce1f51b5ceb72272ea2d733ec97
Parents: f4470af
Author: Sean Mackrory <ma...@apache.org>
Authored: Sat May 28 15:31:17 2016 -0600
Committer: stack <st...@apache.org>
Committed: Sat May 28 21:34:07 2016 -0700
----------------------------------------------------------------------
.../main/java/org/apache/hadoop/hbase/rest/ScannerResource.java | 1 -
.../main/java/org/apache/hadoop/hbase/rest/TableResource.java | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/4abc602e/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java
----------------------------------------------------------------------
diff --git a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java
index 6c424ce..844ea3b 100644
--- a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java
+++ b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java
@@ -91,7 +91,6 @@ public class ScannerResource extends ResourceBase {
spec = new RowSpec(model.getStartRow(), endRow, model.getColumns(), model.getStartTime(),
model.getEndTime(), model.getMaxVersions());
}
- MultivaluedMap<String, String> params = uriInfo.getQueryParameters();
try {
Filter filter = ScannerResultGenerator.buildFilterFromModel(model);
http://git-wip-us.apache.org/repos/asf/hbase/blob/4abc602e/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
----------------------------------------------------------------------
diff --git a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
index f87ef7e..45e9125 100644
--- a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
+++ b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
@@ -192,8 +192,8 @@ public class TableResource extends ResourceBase {
}
int fetchSize = this.servlet.getConfiguration().getInt(Constants.SCAN_FETCH_SIZE, 10);
tableScan.setCaching(fetchSize);
- return new TableScanResource(hTable.getScanner(tableScan), userRequestedLimit);
- } catch (Exception exp) {
+ return new TableScanResource(hTable.getScanner(tableScan), userRequestedLimit);
+ } catch (IOException exp) {
servlet.getMetrics().incrementFailedScanRequests(1);
processException(exp);
LOG.warn(exp);