You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Maja Kabiljo <ma...@fb.com> on 2013/02/08 01:29:41 UTC
Review Request: GIRAPH-508: Increase the limit on the number of partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9370/
-----------------------------------------------------------
Review request for giraph.
Description
-------
Make more compact serialization for PartitionOwners, so we could increase the limit for the total number of partitions.
This addresses bug GIRAPH-508.
https://issues.apache.org/jira/browse/GIRAPH-508
Diffs
-----
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 9ca1e7e
giraph-core/src/main/java/org/apache/giraph/graph/AddressesAndPartitionsWritable.java 990b04e
giraph-core/src/main/java/org/apache/giraph/partition/BasicPartitionOwner.java c1df04b
giraph-core/src/main/java/org/apache/giraph/partition/HashMasterPartitioner.java fc56216
giraph-core/src/main/java/org/apache/giraph/partition/PartitionOwner.java a886d79
giraph-core/src/main/java/org/apache/giraph/partition/RangePartitionOwner.java 1ecedb8
Diff: https://reviews.apache.org/r/9370/diff/
Testing
-------
Run on real application with 200 workers and 40k partitions
mvn clean verify
Thanks,
Maja Kabiljo
Re: Review Request: GIRAPH-508: Increase the limit on the number of
partitions
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9370/#review16315
-----------------------------------------------------------
Ship it!
+1 Looks great!
giraph-core/src/main/java/org/apache/giraph/graph/AddressesAndPartitionsWritable.java
<https://reviews.apache.org/r/9370/#comment34790>
Possible minor change to this comment:
// Also write out the previous worker information that are used in the partition owners
- Avery Ching
On Feb. 8, 2013, 12:29 a.m., Maja Kabiljo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9370/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 12:29 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Make more compact serialization for PartitionOwners, so we could increase the limit for the total number of partitions.
>
>
> This addresses bug GIRAPH-508.
> https://issues.apache.org/jira/browse/GIRAPH-508
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 9ca1e7e
> giraph-core/src/main/java/org/apache/giraph/graph/AddressesAndPartitionsWritable.java 990b04e
> giraph-core/src/main/java/org/apache/giraph/partition/BasicPartitionOwner.java c1df04b
> giraph-core/src/main/java/org/apache/giraph/partition/HashMasterPartitioner.java fc56216
> giraph-core/src/main/java/org/apache/giraph/partition/PartitionOwner.java a886d79
> giraph-core/src/main/java/org/apache/giraph/partition/RangePartitionOwner.java 1ecedb8
>
> Diff: https://reviews.apache.org/r/9370/diff/
>
>
> Testing
> -------
>
> Run on real application with 200 workers and 40k partitions
> mvn clean verify
>
>
> Thanks,
>
> Maja Kabiljo
>
>