You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/07/21 03:11:39 UTC
Review Request 36629: stout: Added support for 'synchronized_wait'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
Diff: https://reviews.apache.org/r/36629/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 36629: stout: Added support for
'synchronized_wait'.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92816
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Harutyunyan
On July 22, 2015, 12:07 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 12:07 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
>
> Diff: https://reviews.apache.org/r/36629/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 36629: stout: Added support for
'synchronized_wait'.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92800
-----------------------------------------------------------
Ship it!
- Joseph Wu
On July 22, 2015, 12:07 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 12:07 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
>
> Diff: https://reviews.apache.org/r/36629/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 36629: stout: Added support for
'synchronized_wait'.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/
-----------------------------------------------------------
(Updated July 22, 2015, 7:07 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Changes
-------
Address BenH's comments.
* Wrap comments at 70 chars.
* References to pointers.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
Diff: https://reviews.apache.org/r/36629/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 36629: stout: Added support for
'synchronized_wait'.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92537
-----------------------------------------------------------
Ship it!
Great, can we do the 70 character comment wraps here though? Thanks!
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 165)
<https://reviews.apache.org/r/36629/#comment146743>
s/support/supported/
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 177)
<https://reviews.apache.org/r/36629/#comment146744>
Can we use pointers here and below please? Thanks!
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 210)
<https://reviews.apache.org/r/36629/#comment146746>
Newline before we start this comment and the one below?
3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 230)
<https://reviews.apache.org/r/36629/#comment146745>
Awesome awesome awesome sauce.
- Benjamin Hindman
On July 21, 2015, 1:11 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 1:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
>
> Diff: https://reviews.apache.org/r/36629/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 36629: stout: Added support for
'synchronized_wait'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92371
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36629]
All tests passed.
- Mesos ReviewBot
On July 21, 2015, 1:11 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36629/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 1:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85
>
> Diff: https://reviews.apache.org/r/36629/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>