You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/02/03 22:56:19 UTC
[PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` [spark]
dongjoon-hyun opened a new pull request, #49780:
URL: https://github.com/apache/spark/pull/49780
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940333677
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
Maybe, are you considering removing this `ServiceLoader` pattern, @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #49780:
URL: https://github.com/apache/spark/pull/49780#issuecomment-2649068810
Thank you, @yaooqinn .
Merged to master for Apache Spark 4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940317415
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
I understand we won't likely remove `SparkSessionExtensions`, and this is service loader for `SparkSessionExtensions` (as mentioned in PR description). But I would prefer to avoid promoting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940336911
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
I am fine if others are okay - I don't have a strong opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940336311
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
I mean, nothing will be affected by this ... I just worry that more people may `SparkSessionExtensions` itself...
TBH, I personally don't like this `SparkSessionExtensions` in general because it opens too much catalyst API usage, and touching rules.. and I was thinking about having them all as `Unstable` for now..
I actually don't like all those API ... such as `df.queryExecution`, etc. for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940315589
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
Oh actually, I would prefer to have this as unstable because it can touch stuff like optimizer and analyzer rules that are internal API..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940333083
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
Could you elaborate a little more about how `SparkSessionExtensionsProvider` are affected with a change of `SparkSessionExtensions`? IIUC, we are not going to remove or rename class `SparkSessionExtensions` .
```scala
trait SparkSessionExtensionsProvider extends Function1[SparkSessionExtensions, Unit]
```
`ServiceLoader` is only related to the relation between the text resource file and class name, `SparkSessionExtensions`, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940336311
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
I mean, nothing will be affected by this ... I just worry about using `SparkSessionExtensions` itself...
TBH, I personally don't like this `SparkSessionExtensions` in general because it opens too much catalyst API usage, and touching rules.. and I was thinking about having them all as `Unstable` for now..
I actually don't like all those API ... such as `df.queryExecution`, etc. for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #49780:
URL: https://github.com/apache/spark/pull/49780#issuecomment-2632373342
Hi, @yaooqinn . WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #49780:
URL: https://github.com/apache/spark/pull/49780#discussion_r1940342243
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala:
##########
@@ -76,7 +74,6 @@ import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
* @since 3.2.0
*/
@DeveloperApi
-@Unstable
Review Comment:
Yes, I understand your concerns fully. I also understand why this is in this status. However, Apache Spark depends on this since v2.2.0 (SPARK-18127) because this is the only way for certain features.
The goal of this PR is only this `ServiceLoader` pattern is applicable in the stable contract for the production usage (SRE or dev team) in Spark 4.1.0.
If many people are reluctant, I'm also going to drop this~ So, let's see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #49780: [SPARK-51073][SQL] Remove `Unstable` from `SparkSessionExtensionsProvider` trait
URL: https://github.com/apache/spark/pull/49780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org