You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/31 16:54:00 UTC
[jira] [Work logged] (HIVE-26684) Upgrade maven-shade-plugin from 3.4.1 for bug fixes.
[ https://issues.apache.org/jira/browse/HIVE-26684?focusedWorklogId=822021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822021 ]
ASF GitHub Bot logged work on HIVE-26684:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/22 16:53
Start Date: 31/Oct/22 16:53
Worklog Time Spent: 10m
Work Description: cnauroth opened a new pull request, #3717:
URL: https://github.com/apache/hive/pull/3717
### What changes were proposed in this pull request?
The Hive build currently runs with maven-shade-plugin version 3.1.1, released in April 2018. This issue proposes to upgrade to the latest version, 3.4.1, released in October 2022.
The new version by default also generates `dependency-reduced-pom.xml` files, as documented here: [`createDependencyReducedPom`](https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#createDependencyReducedPom). These files don't need to go into source control, and it's common to put a pattern in .gitignore.
### Why are the changes needed?
See [HIVE-26648](https://issues.apache.org/jira/browse/HIVE-26648) for an example of another patch that is blocked due to a bug in version 3.1.1.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I applied the [HIVE-26648](https://issues.apache.org/jira/browse/HIVE-26648) patch locally and tried to build:
```
mvn clean package -Piceberg -DskipTests
```
I observed the same `IllegalArgumentException` shown in that patch's [Jenkins CI run](http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3688/1/pipeline/). I then applied my patch, reran the build, and it was successful.
Issue Time Tracking
-------------------
Worklog Id: (was: 822021)
Remaining Estimate: 0h
Time Spent: 10m
> Upgrade maven-shade-plugin from 3.4.1 for bug fixes.
> ----------------------------------------------------
>
> Key: HIVE-26684
> URL: https://issues.apache.org/jira/browse/HIVE-26684
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Hive build currently runs with maven-shade-plugin version 3.1.1, released in April 2018. This issue proposes to upgrade to the latest version, 3.4.1, released in October 2022. See HIVE-26648 for an example of another patch that is blocked due to a bug in version 3.1.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)