[jira] [Updated] (WW-4421) Duplicate @Action value annotation check skipped

["Sebastian Haas (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WW-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Haas updated WW-4421:
-------------------------------
    Attachment: MethodCheckSkippedOnStartup.java
                MethodCheckFailsOnStartup.java

MethodCheckFailsOnStartup.java has the expected behavior.
MethodCheckSkippedOnStartup.java ignores the duplicate action name annotation

> Duplicate @Action value annotation check skipped
> ------------------------------------------------
>
>                 Key: WW-4421
>                 URL: https://issues.apache.org/jira/browse/WW-4421
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Annotations, Plugin - Convention
>    Affects Versions: 2.3.16.3, 2.3.x
>            Reporter: Sebastian Haas
>         Attachments: MethodCheckFailsOnStartup.java, MethodCheckSkippedOnStartup.java
>
>
> {{PackageBasedActionConfigBuilder#buildConfiguration}} checks if there are duplicate action names on method annotations. If {{ActionSupport#execute}} is overridden and annotated with {{@Action}}, the duplicate action name check is skipped.
> The check is disabled due to {code:title=PackageBasedActionConfigBuilder.java:674}if (!map.containsKey(DEFAULT_METHOD){code}
> Having duplicate action names leads to different behavior with Java 7 or Java 8 environment (due to reflection method order).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)