You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/06 01:45:45 UTC
Review Request: Build updates (see description).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/
-----------------------------------------------------------
Review request for mesos and Charles Reiss.
Summary
-------
Build updates:
* Have libprocess only build a convenience library by default (so nothing gets installed).
* Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
* Actually force build.cpp to get recompiled.
* Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
* Added leveldb to python/setup.py.in (given the previous).
NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
Diffs
-----
configure.ac d61c893
src/Makefile.am 1137a3e
src/python/native/proxy_scheduler.cpp bc0c43f
src/python/setup.py.in 472094e
third_party/libprocess/Makefile.am 48ee256
third_party/libprocess/configure.ac ace13e0
Diff: https://reviews.apache.org/r/4187/diff
Testing
-------
make && make check && make install DESTDIR=/tmp/mesos
Thanks,
Benjamin
Re: Review Request: Build updates (see description).
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-03-06 01:36:10, Charles Reiss wrote:
> > src/Makefile.am, line 237
> > <https://reviews.apache.org/r/4187/diff/2/?file=88440#file88440line237>
> >
> > Can we please not modify $(srcdir) during an out-of-source build?
> >
> > Also, why was the previous definition of FORCE insufficient?
>
> Benjamin Hindman wrote:
> It previously only re-linked the libbuild.la, rather than actually recompiling build.cpp. If you have a better suggestion, I'd love to hear it.
Wouldn't making $(srcdir)/common/build.cpp depend on FORCE work?
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5626
-----------------------------------------------------------
On 2012-03-06 00:45:45, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 00:45:45)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-06 01:36:10, Charles Reiss wrote:
> > src/Makefile.am, line 237
> > <https://reviews.apache.org/r/4187/diff/2/?file=88440#file88440line237>
> >
> > Can we please not modify $(srcdir) during an out-of-source build?
> >
> > Also, why was the previous definition of FORCE insufficient?
It previously only re-linked the libbuild.la, rather than actually recompiling build.cpp. If you have a better suggestion, I'd love to hear it.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5626
-----------------------------------------------------------
On 2012-03-06 00:45:45, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 00:45:45)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-06 01:36:10, Charles Reiss wrote:
> > src/Makefile.am, line 237
> > <https://reviews.apache.org/r/4187/diff/2/?file=88440#file88440line237>
> >
> > Can we please not modify $(srcdir) during an out-of-source build?
> >
> > Also, why was the previous definition of FORCE insufficient?
>
> Benjamin Hindman wrote:
> It previously only re-linked the libbuild.la, rather than actually recompiling build.cpp. If you have a better suggestion, I'd love to hear it.
>
> Charles Reiss wrote:
> Wouldn't making $(srcdir)/common/build.cpp depend on FORCE work?
No, that didn't work (which makes sense to me). Alternatively maybe there is a way with BUILT_SOURCES?
> On 2012-03-06 01:36:10, Charles Reiss wrote:
> > third_party/libprocess/Makefile.am, line 64
> > <https://reviews.apache.org/r/4187/diff/2/?file=88443#file88443line64>
> >
> > Don't you want the directory to be include/process instead anyways?
> >
> > Suggest myincludedir=$(includedir)/process and myinclude_HEADERS = ... (assuming you don't want to change configure.ac)
Yes, I did want that, but that still doesn't keep an empty "process" directory from getting created.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5626
-----------------------------------------------------------
On 2012-03-06 00:45:45, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 00:45:45)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5626
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/4187/#comment12247>
Can we please not modify $(srcdir) during an out-of-source build?
Also, why was the previous definition of FORCE insufficient?
third_party/libprocess/Makefile.am
<https://reviews.apache.org/r/4187/#comment12246>
Don't you want the directory to be include/process instead anyways?
Suggest myincludedir=$(includedir)/process and myinclude_HEADERS = ... (assuming you don't want to change configure.ac)
- Charles
On 2012-03-06 00:45:45, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 00:45:45)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-09 00:36:34, Charles Reiss wrote:
> > LGTM.
Alright, I'm committing this without the forcing the rebuild of build.cpp complexities. We can revisit this in the future if we decide this is really important.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5762
-----------------------------------------------------------
On 2012-03-08 23:47:37, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 23:47:37)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/common/build.cpp e7b43c4
> src/common/build.cpp.in PRE-CREATION
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/#review5762
-----------------------------------------------------------
Ship it!
LGTM.
third_party/libprocess/configure.ac
<https://reviews.apache.org/r/4187/#comment12557>
I'd prefer to just remove this option.
- Charles
On 2012-03-08 23:47:37, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4187/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 23:47:37)
>
>
> Review request for mesos and Charles Reiss.
>
>
> Summary
> -------
>
> Build updates:
> * Have libprocess only build a convenience library by default (so nothing gets installed).
> * Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
> * Actually force build.cpp to get recompiled.
> * Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
> * Added leveldb to python/setup.py.in (given the previous).
>
> NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
>
>
> Diffs
> -----
>
> configure.ac d61c893
> src/Makefile.am 1137a3e
> src/common/build.cpp e7b43c4
> src/common/build.cpp.in PRE-CREATION
> src/python/native/proxy_scheduler.cpp bc0c43f
> src/python/setup.py.in 472094e
> third_party/libprocess/Makefile.am 48ee256
> third_party/libprocess/configure.ac ace13e0
>
> Diff: https://reviews.apache.org/r/4187/diff
>
>
> Testing
> -------
>
> make && make check && make install DESTDIR=/tmp/mesos
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Build updates (see description).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/
-----------------------------------------------------------
(Updated 2012-03-12 20:21:47.750410)
Review request for mesos and Charles Reiss.
Changes
-------
For posterity, I've uploaded the final patch applied.
Summary
-------
Build updates:
* Have libprocess only build a convenience library by default (so nothing gets installed).
* Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
* Actually force build.cpp to get recompiled.
* Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
* Added leveldb to python/setup.py.in (given the previous).
NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
Diffs (updated)
-----
configure.ac d61c893
src/Makefile.am 1137a3e
src/common/build.hpp 9dba632
src/common/build.cpp e7b43c4
src/python/native/proxy_scheduler.cpp bc0c43f
src/python/setup.py.in 472094e
third_party/libprocess/Makefile.am 48ee256
third_party/libprocess/configure.ac ace13e0
Diff: https://reviews.apache.org/r/4187/diff
Testing
-------
make && make check && make install DESTDIR=/tmp/mesos
Thanks,
Benjamin
Re: Review Request: Build updates (see description).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4187/
-----------------------------------------------------------
(Updated 2012-03-08 23:47:37.041171)
Review request for mesos and Charles Reiss.
Changes
-------
Changes based on review comments.
Summary
-------
Build updates:
* Have libprocess only build a convenience library by default (so nothing gets installed).
* Remove libev from Mesos makefiles (as well as src/python/setup.py.in).
* Actually force build.cpp to get recompiled.
* Added libleveldb.a directly to libmesos.la so that it wasn't included in the installed libmesos.la in 'dependency_lib'.
* Added leveldb to python/setup.py.in (given the previous).
NOTE: Unfortunately when installing there is still a $(prefix)/include/libprocess directory created. It would be nice to eliminate that!
Diffs (updated)
-----
configure.ac d61c893
src/Makefile.am 1137a3e
src/common/build.cpp e7b43c4
src/common/build.cpp.in PRE-CREATION
src/python/native/proxy_scheduler.cpp bc0c43f
src/python/setup.py.in 472094e
third_party/libprocess/Makefile.am 48ee256
third_party/libprocess/configure.ac ace13e0
Diff: https://reviews.apache.org/r/4187/diff
Testing
-------
make && make check && make install DESTDIR=/tmp/mesos
Thanks,
Benjamin