Re: [PR] feat: Add checkbox to enable/disable params in HTTP Sampler [jmeter]

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #6291:
URL: https://github.com/apache/jmeter/pull/6291#discussion_r1914953302


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/HTTPArgument.java:
##########
@@ -134,14 +134,15 @@ public HTTPArgument(String name, String value, boolean alreadyEncoded) {
     }
 
     /**
-     * Construct a new HTTPArgument instance; alwaysEncoded is set to true.
+     * Construct a new HTTPArgument instance; enabled and alwaysEncoded set to true.
      *
      * @param name the name of the parameter
      * @param value the value of the parameter
      * @param alreadyEncoded true if the name and value is already encoded, in which case they are decoded before storage.
      * @param contentEncoding the encoding used for the parameter value
      */
     public HTTPArgument(String name, String value, boolean alreadyEncoded, String contentEncoding) {
+        setEnabled(true);

Review Comment:
   Is this really needed? `enabled` is the default state, so I am not sure what is the reason of adding it here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org