You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/29 04:01:19 UTC

[PR] refactor(workflow-core, v1.2): make JSONToMap iterative to avoid stack overflow [texera]

Yicong-Huang opened a new pull request, #6991:
URL: https://github.com/apache/texera/pull/6991

   ### What changes were proposed in this PR?
   
   Backport of #5322 to `release/v1.2`, cherry-picked from 2f9573be88e7f73e63e7f2f441187a5977fdb0a3. The cherry-pick applied cleanly.
   
   Follows the Direct Backport Push convention; opened as a PR (rather than a direct push) per a backport-coverage audit.
   
   ### Any related issues, documentation, discussions?
   
   Backport of #5322.
   
   ### How was this PR tested?
   
   Release-branch CI runs on this PR. Cherry-pick applied cleanly onto `release/v1.2`; no manual conflict resolution was needed.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Yes — backport prepared with Claude Code (mechanical cherry-pick; the change itself is #5322 by its original author).
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(workflow-core, v1.2): make JSONToMap iterative to avoid stack overflow [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6991:
URL: https://github.com/apache/texera/pull/6991#issuecomment-5113025718

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@Ma77Ball`
     You can notify them by mentioning `@Ma77Ball` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(workflow-core, v1.2): make JSONToMap iterative to avoid stack overflow [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #6991:
URL: https://github.com/apache/texera/pull/6991


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(workflow-core, v1.2): make JSONToMap iterative to avoid stack overflow [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6991:
URL: https://github.com/apache/texera/pull/6991#issuecomment-5113212430

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6991?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 53.93%. Comparing base ([`fd5f487`](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`52e6e97`](https://app.codecov.io/gh/apache/texera/commit/52e6e97bb420994eb9d15046ddb00b8be39e8be1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :white_check_mark: All tests successful. No failed tests found.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@                Coverage Diff                 @@
   ##             release/v1.2    #6991      +/-   ##
   ==================================================
   - Coverage           53.95%   53.93%   -0.02%     
     Complexity           1441     1441              
   ==================================================
     Files                 809      809              
     Lines               34144    34132      -12     
     Branches             3448     3445       -3     
   ==================================================
   - Hits                18421    18410      -11     
     Misses              14815    14815              
   + Partials              908      907       -1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.61% <ø> (ø)` | | |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.55% <ø> (-0.06%)` | :arrow_down: | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.59% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.19% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.87% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [python](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.74% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6991?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org