You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/05/09 15:58:17 UTC
Review Request 59101: Enabled authorization for v1 API call
GET_MAINTENANCE_STATUS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/
-----------------------------------------------------------
Review request for mesos, Adam B and Greg Mann.
Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415
Repository: mesos
Description
-------
Enables the use of authorization for the `GET_MAINTENANCE_STATUS`
v1 API call, using the ACL `GetMaintenanceStatus` and the action
of the same name as the API call.
It also updates the `ApiTests` to take into account the authorization
case.
Diffs
-----
src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
Diff: https://reviews.apache.org/r/59101/diff/1/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 59101: Enabled authorization for v1 API call
GET_MAINTENANCE_STATUS.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/
-----------------------------------------------------------
(Updated May 24, 2017, 3:29 p.m.)
Review request for mesos, Adam B and Greg Mann.
Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415
Repository: mesos
Description (updated)
-------
Enables the use of authorization for the `GET_MAINTENANCE_STATUS`
v1 API call, using the ACL `GetMaintenanceStatus` and the action
of the same name as the API call.
It also updates the ApiTests to take into account the authorization
case.
Diffs (updated)
-----
src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
Diff: https://reviews.apache.org/r/59101/diff/4/
Changes: https://reviews.apache.org/r/59101/diff/3-4/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 59101: Enabled authorization for v1 API call
GET_MAINTENANCE_STATUS.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/
-----------------------------------------------------------
(Updated May 23, 2017, 3:55 p.m.)
Review request for mesos, Adam B and Greg Mann.
Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415
Repository: mesos
Description (updated)
-------
Enables the use of authorization for the `GET_MAINTENANCE_STATUS`
v1 API call, using the ACL `GetMaintenanceStatus` and the action
of the same name as the API call.
It also updates the `ApiTests` to take into account the authorization
case.
Diffs (updated)
-----
src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
Diff: https://reviews.apache.org/r/59101/diff/3/
Changes: https://reviews.apache.org/r/59101/diff/2-3/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 59101: Enabled authorization for v1 API call
GET_MAINTENANCE_STATUS.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/
-----------------------------------------------------------
(Updated May 12, 2017, 4:25 p.m.)
Review request for mesos, Adam B and Greg Mann.
Bugs: MESOS-7415
https://issues.apache.org/jira/browse/MESOS-7415
Repository: mesos
Description (updated)
-------
Enables the use of authorization for the `GET_MAINTENANCE_STATUS`
v1 API call, using the ACL `GetMaintenanceStatus` and the action
of the same name as the API call.
It also updates the ApiTests to take into account the authorization
case.
Diffs (updated)
-----
src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
Diff: https://reviews.apache.org/r/59101/diff/2/
Changes: https://reviews.apache.org/r/59101/diff/1-2/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 59101: Enabled authorization for v1 API call
GET_MAINTENANCE_STATUS.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/#review174405
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58955, 58964, 59099, 59100, 59101]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 9, 2017, 3:58 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59101/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 3:58 p.m.)
>
>
> Review request for mesos, Adam B and Greg Mann.
>
>
> Bugs: MESOS-7415
> https://issues.apache.org/jira/browse/MESOS-7415
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enables the use of authorization for the `GET_MAINTENANCE_STATUS`
> v1 API call, using the ACL `GetMaintenanceStatus` and the action
> of the same name as the API call.
>
> It also updates the `ApiTests` to take into account the authorization
> case.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
> src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09
>
>
> Diff: https://reviews.apache.org/r/59101/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>