You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/09/04 18:42:22 UTC

[kudu-CR] build: retry all failed tests

Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11374

to look at the new patch set (#4).

Change subject: build: retry all failed tests
......................................................................

build: retry all failed tests

Previously, the option KUDU_FLAKY_TEST_ATTEMPTS, would either pull the
list of flaky tests from the test server and retry those tests, or retry
all failed tests if specified by the user. This patch updates the unit
test run logic to retry all failed tests as long as
KUDU_FLAKY_TEST_ATTEMPST is set. Now, the flaky test list will only be
used to specify which tests to run, e.g. if RUN_FLAKY_ONLY is set.

The new default when running build-and-test.sh will be to retry failed
tests 3 times. If running without dist-test, this is handled naturally
by running run-test.sh with the KUDU_FLAKY_TEST_ATTEMPTS environment
variable. If running with dist-test, the tasks' 'max_retries' field is
set appropriately.

I tested this locally by running run-test.sh with a dummy failed test,
setting KUDU_FLAKY_TEST_ATTEMPTS to a couple different values.

Here are some dist test runs with KUDU_FLAKY_TEST_ATTEMPTS=3:
http://dist-test.cloudera.org/job?job_id=awong.1536084217.20341

One with KUDU_FLAKY_TEST_ATTEMPTS unset:
http://dist-test.cloudera.org/job?job_id=awong.1536084777.22826

Change-Id: I6fc069527d6f2553a4e04e14c821090f826cbc0a
---
M build-support/dist_test.py
M build-support/jenkins/build-and-test.sh
M build-support/run-test.sh
3 files changed, 17 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/11374/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fc069527d6f2553a4e04e14c821090f826cbc0a
Gerrit-Change-Number: 11374
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>