You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2024/02/14 23:00:15 UTC
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21034
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
It is possible to configure Impala to use SSL when connecting to HBase.
Under the covers, an HBase client connection also has a connection to
ZooKeeper. SSL connections to ZooKeeper require Netty. Netty has been
excluded from Impala’s classpath since IMPALA-9648 because of earlier
security problems. IMPALA-9648 says that we need to be at least at
version 4.1.44 of Netty and we now pull in 4.1.86. To allow use of SSL
with HBase, remove the exclusion of Netty.
TESTING:
Ran end-to-end tests.
Ran queries against HBase configured to use SSL in a Cloudera
deployment.
Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
---
M fe/pom.xml
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/21034/1
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10280/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:57:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10276/
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 04:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 23:33:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 22:34:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:57:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
It is possible to configure Impala to use SSL when connecting to HBase.
Under the covers, an HBase client connection also has a connection to
ZooKeeper. SSL connections to ZooKeeper require Netty. Netty has been
excluded from Impala’s classpath since IMPALA-9648 because of earlier
security problems. IMPALA-9648 says that we need to be at least at
version 4.1.44 of Netty and we now pull in 4.1.86. To allow use of SSL
with HBase, remove the exclusion of Netty.
TESTING:
Ran end-to-end tests.
Ran queries against HBase configured to use SSL in a Cloudera
deployment.
Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Reviewed-on: http://gerrit.cloudera.org:8080/21034
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 0 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 23:31:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10276/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 23:33:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15239/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 23:27:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21034 )
Change subject: IMPALA-12816: Remove exclusion of Netty to allow SSL connections to HBase
......................................................................
Patch Set 2:
Looks like flaky IMPALA-1995
(though I don't like seeing HBase errors when I am changing something that affects HBase)
--
To view, visit http://gerrit.cloudera.org:8080/21034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3038369345ca74f01ce2d4248c5beb21b633b2b
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:51:50 +0000
Gerrit-HasComments: No