You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2012/04/26 13:37:17 UTC

[jira] [Created] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Uwe Schindler created LUCENE-4023:
-------------------------------------

             Summary: Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
                 Key: LUCENE-4023
                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 3.6, 3.5, 3.4, 3.3, 3.2, 3.1
            Reporter: Uwe Schindler
            Assignee: Uwe Schindler
             Fix For: 3.6.1


Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.

I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():

If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.

This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler resolved LUCENE-4023.
-----------------------------------

    Resolution: Fixed

Committed to realease branch revision: 1331296
                
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6.1
>
>         Attachments: LUCENE-4023.patch
>
>
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.
> I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():
> If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.
> This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262572#comment-13262572 ] 

Michael McCandless commented on LUCENE-4023:
--------------------------------------------

+1
                
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6.1
>
>         Attachments: LUCENE-4023.patch
>
>
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.
> I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():
> If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.
> This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-4023:
----------------------------------

    Attachment: LUCENE-4023.patch

Patch. The change in DisjMaxScorer should be forward-ported to new trunk API.
                
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6.1
>
>         Attachments: LUCENE-4023.patch
>
>
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.
> I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():
> If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.
> This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262553#comment-13262553 ] 

Michael McCandless commented on LUCENE-4023:
--------------------------------------------

+1
                
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6.1
>
>
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.
> I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():
> If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.
> This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4023) Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-4023:
----------------------------------

    Component/s: core/search
    
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4023
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6.1
>
>
> Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.
> I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():
> If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.
> This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org