[GitHub] tajo pull request: TAJO-839: If all tables participate in the BROA...

[jihoonson <gi...@git.apache.org>]

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/17#discussion_r13340790
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java ---
    @@ -844,16 +844,15 @@ private boolean checkIfSortEquivalance(TaskAttemptContext ctx, ScanNode scanNode
     
       public PhysicalExec createScanPlan(TaskAttemptContext ctx, ScanNode scanNode, Stack<LogicalNode> node)
           throws IOException {
    -    if (ctx.getTable(scanNode.getCanonicalName()) == null) {
    -      return new SeqScanExec(ctx, sm, scanNode, null);
    -    }
    -    Preconditions.checkNotNull(ctx.getTable(scanNode.getCanonicalName()),
    -        "Error: There is no table matched to %s", scanNode.getCanonicalName() + "(" + scanNode.getTableName() + ")");    
    -
         // check if an input is sorted in the same order to the subsequence sort operator.
         // TODO - it works only if input files are raw files. We should check the file format.
         // Since the default intermediate file format is raw file, it is not problem right now.
         if (checkIfSortEquivalance(ctx, scanNode, node)) {
    +      if (ctx.getTable(scanNode.getCanonicalName()) == null) {
    +        return new SeqScanExec(ctx, sm, scanNode, null);
    +      }
    +      Preconditions.checkNotNull(ctx.getTable(scanNode.getCanonicalName()),
    --- End diff --
    
    It seems unnecessary because the above if clause checks the same condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---