You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/15 12:11:56 UTC
[GitHub] [flink-connector-elasticsearch] zentol opened a new pull request, #37: [FLINK-29310][ci] Check licensing
zentol opened a new pull request, #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37
Runs the NoticeFileChecker on CI.
Additionally changes CI logging to output to the console, since otherwise we don't see any license checker output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #37: [FLINK-29310][ci] Check licensing
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r971912006
##########
pom.xml:
##########
@@ -51,6 +51,15 @@ under the License.
</developerConnection>
</scm>
+ <pluginRepositories>
+ <pluginRepository>
+ <!-- Allows exec-maven-plugin to resolve snapshot plugin dependencies -->
Review Comment:
Basically, plugins set on the dependency are only looked up in specific repositories, and apparently not in those that we have configured :shrug:
##########
pom.xml:
##########
@@ -753,6 +762,35 @@ under the License.
<extensions>true</extensions>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <inherited>false</inherited>
Review Comment:
We dont want to run this multiple times. The checker is not written to only consider part of the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol merged pull request #37: [FLINK-29310][ci] Check licensing
Posted by GitBox <gi...@apache.org>.
zentol merged PR #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #37: [FLINK-29310][ci] Check licensing
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r972093380
##########
.github/workflows/ci.yml:
##########
@@ -53,9 +56,20 @@ jobs:
- name: Compile and test flink-connector-elasticsearch
timeout-minutes: 20
run: |
- mvn clean install -U -B --no-transfer-progress \
+ set -o pipefail
+
+ mvn clean deploy ${MVN_COMMON_OPTIONS} \
+ -DaltDeploymentRepository=validation_repository::default::file:${{ env.MVN_VALIDATION_DIR }} \
-Dscala-2.12 \
-Prun-end-to-end-tests -DdistDir=$(pwd)/../flink-1.16-SNAPSHOT \
-Dflink.convergence.phase=install -Pcheck-convergence \
${{ env.MVN_CONNECTION_OPTIONS }} \
+ -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties \
+ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }}
+
+ - name: Check licensing
Review Comment:
We could only do that if we again split of the compile & test steps (costing us time), and I'd like to avoid that as long as we are running on ASF infrastructure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #37: [FLINK-29310][ci] Check licensing
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r972085632
##########
.github/workflows/ci.yml:
##########
@@ -53,9 +56,20 @@ jobs:
- name: Compile and test flink-connector-elasticsearch
timeout-minutes: 20
run: |
- mvn clean install -U -B --no-transfer-progress \
+ set -o pipefail
+
+ mvn clean deploy ${MVN_COMMON_OPTIONS} \
+ -DaltDeploymentRepository=validation_repository::default::file:${{ env.MVN_VALIDATION_DIR }} \
-Dscala-2.12 \
-Prun-end-to-end-tests -DdistDir=$(pwd)/../flink-1.16-SNAPSHOT \
-Dflink.convergence.phase=install -Pcheck-convergence \
${{ env.MVN_CONNECTION_OPTIONS }} \
+ -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties \
+ | tee ${{ env.MVN_BUILD_OUTPUT_FILE }}
+
+ - name: Check licensing
Review Comment:
Thought if we should consider moving the license checker earlier but I think there's little value in that, given the amount of time it takes for a testrun to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #37: [FLINK-29310][ci] Check licensing
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #37:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r971912006
##########
pom.xml:
##########
@@ -51,6 +51,15 @@ under the License.
</developerConnection>
</scm>
+ <pluginRepositories>
+ <pluginRepository>
+ <!-- Allows exec-maven-plugin to resolve snapshot plugin dependencies -->
Review Comment:
Basically, dependencies set on the plugin are only looked up in plugin repositories, and apparently not in those that we have configured for "normal" dependencies :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org