You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/11 00:14:16 UTC

[GitHub] [beam] TheNeuralBit opened a new issue, #21812: [Task]: Update all jira references in the codebase to the migrated issue

TheNeuralBit opened a new issue, #21812:
URL: https://github.com/apache/beam/issues/21812

   ### What needs to happen?
   
   There are many places in the codebase where we reference jiras, some examples:
    https://github.com/apache/beam/blob/e634efe491cc8dd45b44b7da48bca9f207d90904/sdks/python/apache_beam/dataframe/frame_base.py#L418
    https://github.com/apache/beam/blob/b8e2e85ab1fb37a2f89ed20d88730e591ea3bf7e/sdks/python/apache_beam/ml/inference/sklearn_inference_test.py#L174
   
   We should update all of these to point to the issues instead.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: project-management


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

damccorm commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1153336443

   Note, I already did this for true links - https://github.com/apache/beam/pull/21749 - this one is a little more involved because it touches real code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

TheNeuralBit commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1154102015

   Ah nice, good to know that #21749 is already done. I might look at fixing just the DataFrame references in docs/error messages then.
   
   Is there a shorthand we can/should use to reference an issue, similar to "BEAM-XXX", or should we always use the full URL? I suppose the convention in the GitHub UI is `#XXXX`, but that doesn't seem reasonable for docs/error messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm closed issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

damccorm closed issue #21812: [Task]: Update all jira references in the codebase to the migrated issue
URL: https://github.com/apache/beam/issues/21812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

TheNeuralBit commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1152812565

   Also, I want to note here that in dataframes we use the jira id to build a jira URL: https://github.com/apache/beam/blob/e634efe491cc8dd45b44b7da48bca9f207d90904/sdks/python/apache_beam/dataframe/frame_base.py#L430
   
   So if/when we do this we'll need to update that to make sure it doesn't start building bad links.
   
   It might be nice to do this before the release cut next Wednesday, since some of the jira references are user-visible (in documentation and error messages).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

TheNeuralBit commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1152811616

   @damccorm do you think you could use the saved jira-to-issue mapping for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

TheNeuralBit commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1155809015

   I wanted to call out https://github.com/apache/beam/pull/21835#discussion_r897400543
   
   Once we're done migrating the jira references, any remaining BEAM-* strings in the code either represent tasks that weren't actually completed, or they're outdated comments that should be removed. We may want to file a separate task to follow up on those.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #21812: [Task]: Update all jira references in the codebase to the migrated issue

Posted by GitBox <gi...@apache.org>.

damccorm commented on issue #21812:
URL: https://github.com/apache/beam/issues/21812#issuecomment-1153336230

   I'll see if I can sneak this in before the cut, might be tight though. Worst case, all the Jiras have backlinks to their migrated issue so the user-visibility shouldn't be the end of the world.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org