[jira] [Commented] (FLINK-2151) Provide interface to distinguish close() calls in error and regular cases

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571704#comment-14571704 ] 

Stephan Ewen commented on FLINK-2151:
-------------------------------------

For rich functions, we can add a {{signalCancel()}} methods. That breaks nothing, because they are regular classes.

For data sinks, it is more tricky. We can add a {{CancelableSink}}

> Provide interface to distinguish close() calls in error and regular cases
> -------------------------------------------------------------------------
>
>                 Key: FLINK-2151
>                 URL: https://issues.apache.org/jira/browse/FLINK-2151
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>
> I was talking to somebody who is interested in contributing a {{flink-cassandra}} connector.
> The connector will create cassandra files locally (on the TaskManagers) and bulk-load them in the {{close()}} method.
> For the user functions it is currently not possible to find out whether the function is closed due to an error or an regular end.
> The simplest approach would be passing an additional argument (enum or boolean) into the close() method, indicating the type of closing.
> But that would break all existing code.
> Another approach would add an interface that has such an extended close method {{RichCloseFunction}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)