You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/04/24 19:54:33 UTC
[GitHub] storm pull request #2644: STORM-3041 improve worker-launcher messages
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2644
STORM-3041 improve worker-launcher messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_worker_launcher
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2644
----
commit d6846873aca280a1e40fea39c619a6a4ba7e3946
Author: Aaron Gresch <ag...@...>
Date: 2018-04-24T19:52:46Z
STORM-3041 improve worker-launcher messages
----
---
[GitHub] storm issue #2644: STORM-3041 improve worker-launcher messages
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2644
@srdo - renamed nm-related methods and variables.
---
[GitHub] storm issue #2644: STORM-3041 improve worker-launcher messages
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2644
@srdo squashed. I think we're good with 2x branch.
---
[GitHub] storm pull request #2644: STORM-3041 improve worker-launcher messages
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2644#discussion_r185330090
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -309,7 +309,7 @@ int set_user(const char *user) {
}
/**
- * Open a file as the node manager and return a file descriptor for it.
+ * Open a file as the worker-launcher user and return a file descriptor for it.
--- End diff --
Is this referring to "node manager" because it was copy pasted, or what is node manager referring to?
Maybe we should rename the functions that refer to "nm" as well?
---
[GitHub] storm pull request #2644: STORM-3041 improve worker-launcher messages
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2644#discussion_r185333948
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -309,7 +309,7 @@ int set_user(const char *user) {
}
/**
- * Open a file as the node manager and return a file descriptor for it.
+ * Open a file as the worker-launcher user and return a file descriptor for it.
--- End diff --
Possibly this code was copied from Hadoop.
---
[GitHub] storm issue #2644: STORM-3041 improve worker-launcher messages
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2644
@agresch Thanks. +1. Please squash to one commit, then we can merge.
If you want this on 1.x branches as well, I think we need a separate PR for that branch (the files have moved).
---
[GitHub] storm pull request #2644: STORM-3041 improve worker-launcher messages
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2644
---