You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 06:17:34 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13455: fixup! Fixed failing pylint errors introduced in #13403 (#13429)
mik-laj opened a new pull request #13455:
URL: https://github.com/apache/airflow/pull/13455
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13455: Remove unused dependency - contextdecorator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13455:
URL: https://github.com/apache/airflow/pull/13455#issuecomment-754053889
@ashb l This library never installs because we don't support Python older than 3.6.
```
$ echo 3.6 3.7 3.8 3.9 | xargs -n 1 -I {} curl -s 'https://raw.githubusercontent.com/apache/airflow/constraints-master/constraints-{}.txt' | sort | uniq | grep -i contextdecorator
$ echo $?
1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13455: Remove unused dependency - contextdecorator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13455:
URL: https://github.com/apache/airflow/pull/13455#issuecomment-754058159
I think my change #6504 was when i brought back coverage (and this line was added in accidentally - but as @mik-laj noticed, it was harmless).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13455: Remove unused dependency - contextdecorator
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13455:
URL: https://github.com/apache/airflow/pull/13455#issuecomment-754059185
Just checking it wasn't some kind of "side-effect needed" but yeah, would only affect py2.7 anyway. Good point :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13455: Remove unused dependency - contextdecorator
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13455:
URL: https://github.com/apache/airflow/pull/13455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org