You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/10/12 08:22:32 UTC

[GitHub] [zeppelin] curlsli commented on a change in pull request #3425: [ZEPPELIN-4301] js double precision loss problem

curlsli commented on a change in pull request #3425: [ZEPPELIN-4301]  js double precision loss problem
URL: https://github.com/apache/zeppelin/pull/3425#discussion_r334227172
 
 

 ##########
 File path: zeppelin-web/src/app/tabledata/tabledata.js
 ##########
 @@ -60,7 +60,7 @@ export default class TableData extends Dataset {
         } else {
           let valueOfCol;
           if (!(col[0] === '0' || col[0] === '+' || col.length > float64MaxDigits)) {
-            if (!isNaN(valueOfCol = parseFloat(col)) && isFinite(col)) {
+            if (!isNaN(valueOfCol = col) && isFinite(col)) {
 
 Review comment:
   I think there is no problem. Because JS is to show that the real operations are run in the interpreter. This is also the simplest solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services