You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/23 15:02:50 UTC
[GitHub] [spark] MaxGekk commented on a change in pull request #32311: [SPARK-35088][SQL] Accept ANSI intervals by the Sequence expression
MaxGekk commented on a change in pull request #32311:
URL: https://github.com/apache/spark/pull/32311#discussion_r619281179
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -744,8 +745,8 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
checkEvaluation(new Sequence(
Literal(Timestamp.valueOf("2018-01-01 00:00:00")),
- Literal(Timestamp.valueOf("2018-01-02 00:00:01")),
Review comment:
Why did you change the test for `CalendarInterval`? It seems it checks a specific case.
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -760,6 +761,15 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Timestamp.valueOf("2018-01-01 12:00:00"),
Timestamp.valueOf("2018-01-01 00:00:00")))
+ checkEvaluation(new Sequence(
Review comment:
nit: The test is already big enough. Does it make sense to put new checks to a separate test and prepend JIRA id?
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -919,6 +1039,23 @@ class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper
Date.valueOf("2020-11-01"),
Date.valueOf("2022-04-01")))
+ checkEvaluation(new Sequence(
+ Literal(Date.valueOf("2018-01-01")),
+ Literal(Date.valueOf("2023-01-01")),
+ Literal(Period.of(1, 5, 0))),
+ Seq(
+ Date.valueOf("2018-01-01"),
+ Date.valueOf("2019-06-01"),
+ Date.valueOf("2020-11-01"),
+ Date.valueOf("2022-04-01")))
+
+ checkExceptionInExpression[IllegalArgumentException](
+ new Sequence(
+ Literal(Date.valueOf("2018-01-01")),
+ Literal(Date.valueOf("2018-01-05")),
+ Literal(Period.ofDays(2))),
+ EmptyRow, "sequence step must be a day interval if start and end values are dates")
Review comment:
`a day interval` -> `a day-time interval`. Please, call `DayTimeIntervalType.typeName()` here. Since the types are not stable yet, we can rename the types in the near future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org