You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jon Travis (JIRA)" <in...@incubator.apache.org> on 2005/03/29 03:14:18 UTC
[jira] Commented: (MYFACES-108) UIInput should not store submitted value in the state
[ http://issues.apache.org/jira/browse/MYFACES-108?page=comments#action_61690 ]
Jon Travis commented on MYFACES-108:
------------------------------------
I am having an issue in the current release (1.0.9 ... head?)
Basically text inputs are coming back from POSTs as "" instead
of 'null' (I don't change any values). When the renderutils check
to see if the object is null, it fails (and thus, always renders "" instead
of grabbing the value from the model bean)
> UIInput should not store submitted value in the state
> -----------------------------------------------------
>
> Key: MYFACES-108
> URL: http://issues.apache.org/jira/browse/MYFACES-108
> Project: MyFaces
> Type: Improvement
> Versions: 1.0.7 beta, 1.0.8 beta
> Reporter: sean schofield
> Priority: Trivial
>
> Submitted value really shouldn't be stored in the state. At a minimum it is confusing and results in extra bandwith with client-side state saving. Heath points out that in most cases the value being "stored" will probably be null. That being said, if the code is totally unecessary we ought to consider removing it. I will leave this issue open for a while to make sure nobody has any issues with fixing it. This will affect a lot of components so I want to be sure this is the right thing to do. I will provide a patch eventually.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (MYFACES-108) UIInput should not store submitted value in the state
Posted by Jon Travis <jt...@p00p.org>.
Likely the problem I'm having is something else. I've
posted on the user list with some more specific details.
-- Jon
On Mar 28, 2005, at 6:54 PM, Adam Winer wrote:
> submittedValue should be stored in saved state.
>
> An example where it actually matters: put an <h:inputText> inside of a
> container that toggles its contents on and off during Apply Request
> Values (<af:showDetail immediate="true"> is an example). Type a value
> into the inputText, and immediately toggle that container shut. When
> you re-expand the container, if you don't save submittedValue, the
> field will be blank.
>
> Optimizing the case where it is null (in general, optimizing state
> saving to deal with the common scenario of lots of not-set properties)
> would be a fine thing, but you shouldn't simply not store it.
>
> The RI, FWIW, does not save submittedValue, which should be a bug (and
> is quite likely my fault!), but ADF Faces does in our input components
> for exactly this reason.
>
> -- Adam Winer
>
>
> On Tue, 29 Mar 2005 03:14:18 +0200 (CEST), Jon Travis (JIRA)
> <in...@incubator.apache.org> wrote:
>> [
>> http://issues.apache.org/jira/browse/MYFACES-108?
>> page=comments#action_61690 ]
>>
>> Jon Travis commented on MYFACES-108:
>> ------------------------------------
>>
>> I am having an issue in the current release (1.0.9 ... head?)
>>
>> Basically text inputs are coming back from POSTs as "" instead
>> of 'null' (I don't change any values). When the renderutils check
>> to see if the object is null, it fails (and thus, always renders ""
>> instead
>> of grabbing the value from the model bean)
>>
>>> UIInput should not store submitted value in the state
>>> -----------------------------------------------------
>>>
>>> Key: MYFACES-108
>>> URL: http://issues.apache.org/jira/browse/MYFACES-108
>>> Project: MyFaces
>>> Type: Improvement
>>> Versions: 1.0.7 beta, 1.0.8 beta
>>> Reporter: sean schofield
>>> Priority: Trivial
>>
>>>
>>> Submitted value really shouldn't be stored in the state. At a
>>> minimum it is confusing and results in extra bandwith with
>>> client-side state saving. Heath points out that in most cases the
>>> value being "stored" will probably be null. That being said, if the
>>> code is totally unecessary we ought to consider removing it. I will
>>> leave this issue open for a while to make sure nobody has any issues
>>> with fixing it. This will affect a lot of components so I want to
>>> be sure this is the right thing to do. I will provide a patch
>>> eventually.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators:
>> http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> If you want more information on JIRA, or have a bug to report see:
>> http://www.atlassian.com/software/jira
>>
>>
>
>
Re: [jira] Commented: (MYFACES-108) UIInput should not store submitted value in the state
Posted by Adam Winer <aw...@gmail.com>.
submittedValue should be stored in saved state.
An example where it actually matters: put an <h:inputText> inside of a
container that toggles its contents on and off during Apply Request
Values (<af:showDetail immediate="true"> is an example). Type a value
into the inputText, and immediately toggle that container shut. When
you re-expand the container, if you don't save submittedValue, the
field will be blank.
Optimizing the case where it is null (in general, optimizing state
saving to deal with the common scenario of lots of not-set properties)
would be a fine thing, but you shouldn't simply not store it.
The RI, FWIW, does not save submittedValue, which should be a bug (and
is quite likely my fault!), but ADF Faces does in our input components
for exactly this reason.
-- Adam Winer
On Tue, 29 Mar 2005 03:14:18 +0200 (CEST), Jon Travis (JIRA)
<in...@incubator.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/MYFACES-108?page=comments#action_61690 ]
>
> Jon Travis commented on MYFACES-108:
> ------------------------------------
>
> I am having an issue in the current release (1.0.9 ... head?)
>
> Basically text inputs are coming back from POSTs as "" instead
> of 'null' (I don't change any values). When the renderutils check
> to see if the object is null, it fails (and thus, always renders "" instead
> of grabbing the value from the model bean)
>
> > UIInput should not store submitted value in the state
> > -----------------------------------------------------
> >
> > Key: MYFACES-108
> > URL: http://issues.apache.org/jira/browse/MYFACES-108
> > Project: MyFaces
> > Type: Improvement
> > Versions: 1.0.7 beta, 1.0.8 beta
> > Reporter: sean schofield
> > Priority: Trivial
>
> >
> > Submitted value really shouldn't be stored in the state. At a minimum it is confusing and results in extra bandwith with client-side state saving. Heath points out that in most cases the value being "stored" will probably be null. That being said, if the code is totally unecessary we ought to consider removing it. I will leave this issue open for a while to make sure nobody has any issues with fixing it. This will affect a lot of components so I want to be sure this is the right thing to do. I will provide a patch eventually.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>