You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/08/16 03:19:18 UTC
[PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
kou opened a new pull request, #43724:
URL: https://github.com/apache/arrow/pull/43724
### Rationale for this change
We can't use thread nor `%z` on Emacripten. Some CSV tests use them.
### What changes are included in this PR?
Skip CSV tests that use thread or `%z`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43724:
URL: https://github.com/apache/arrow/pull/43724#issuecomment-2292657569
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43724:
URL: https://github.com/apache/arrow/pull/43724#issuecomment-2292657650
:warning: GitHub issue #43175 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #43724:
URL: https://github.com/apache/arrow/pull/43724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43724:
URL: https://github.com/apache/arrow/pull/43724#issuecomment-2294591315
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43724:
URL: https://github.com/apache/arrow/pull/43724#issuecomment-2294821533
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 49be60f5c424cca40bbc5a6d1948ad7e800afaab.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/28891464901) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43175: [C++] Skip not Emscripten ready tests in CSV tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43724:
URL: https://github.com/apache/arrow/pull/43724#issuecomment-2292659408
Revision: d54502a5e277fad6c2743bf0e1bb4a77b33db635
Submitted crossbow builds: [ursacomputing/crossbow @ actions-58288f5ac1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-58288f5ac1)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103282/job/28842544225)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103191/job/28842543845)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103411/job/28842544510)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103285/job/28842544186)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103605/job/28842544944)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103273/job/28842544232)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103245/job/28842544107)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103425/job/28842544530)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103708/job/28842544961)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103209/job/28842544059)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103307/job/28842544305)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103809/job/28842544967)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103429/job/28842544796)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103199/job/28842543828)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103441/job/28842544531)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103358/job/28842544516)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103158/job/28842543837)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103159/job/28842543839)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/10414103372/job/28842544351)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org