You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by di...@apache.org on 2026/06/25 13:01:53 UTC
(polaris) branch main updated: Remove createTableDirectWithWriteDelegation method, it is used only in test code (#4725)
This is an automated email from the ASF dual-hosted git repository.
dimas-b pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new ec6f9f489c Remove createTableDirectWithWriteDelegation method, it is used only in test code (#4725)
ec6f9f489c is described below
commit ec6f9f489c3c80648ccec4c8629fd5c0b22a4a53
Author: Nándor Kollár <na...@users.noreply.github.com>
AuthorDate: Thu Jun 25 15:01:49 2026 +0200
Remove createTableDirectWithWriteDelegation method, it is used only in test code (#4725)
---
.../service/catalog/iceberg/IcebergCatalogHandler.java | 15 ---------------
.../iceberg/AbstractIcebergCatalogHandlerAuthzTest.java | 9 +++++++--
2 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
index 46d33faa93..7269307503 100644
--- a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
+++ b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
@@ -427,21 +427,6 @@ public abstract class IcebergCatalogHandler extends CatalogHandler implements Au
namespace, request, EnumSet.noneOf(AccessDelegationMode.class), Optional.empty());
}
- /**
- * Create a table.
- *
- * @param namespace the namespace to create the table in
- * @param request the table creation request
- * @return ETagged {@link LoadTableResponse} to uniquely identify the table metadata
- */
- public LoadTableResponse createTableDirectWithWriteDelegation(
- Namespace namespace,
- CreateTableRequest request,
- Optional<String> refreshCredentialsEndpoint) {
- return createTableDirect(
- namespace, request, EnumSet.of(VENDED_CREDENTIALS), refreshCredentialsEndpoint);
- }
-
public void authorizeCreateTableDirect(
Namespace namespace, CreateTableRequest request, boolean delegationRequested) {
if (delegationRequested) {
diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
index ee598f4f56..d386609535 100644
--- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
+++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
@@ -18,6 +18,8 @@
*/
package org.apache.polaris.service.catalog.iceberg;
+import static org.apache.polaris.service.catalog.AccessDelegationMode.VENDED_CREDENTIALS;
+
import com.google.common.collect.ImmutableMap;
import jakarta.inject.Inject;
import java.time.Instant;
@@ -469,8 +471,11 @@ public abstract class AbstractIcebergCatalogHandlerAuthzTest extends PolarisAuth
.action(
() ->
newHandler(Set.of(PRINCIPAL_ROLE1))
- .createTableDirectWithWriteDelegation(
- NS2, createDirectWithWriteDelegationRequest, Optional.empty()))
+ .createTableDirect(
+ NS2,
+ createDirectWithWriteDelegationRequest,
+ EnumSet.of(VENDED_CREDENTIALS),
+ Optional.empty()))
.cleanupAction(() -> newHandler(Set.of(PRINCIPAL_ROLE2)).dropTableWithPurge(newtable))
.shouldPassWith(PolarisPrivilege.TABLE_CREATE, PolarisPrivilege.TABLE_WRITE_DATA)
.shouldPassWith(PolarisPrivilege.CATALOG_MANAGE_CONTENT)