You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 01:24:17 UTC
[GitHub] [arrow] kou commented on a change in pull request #8315: ARROW-9266: [Python][Packaging] Enable S3 support in macOS wheels
kou commented on a change in pull request #8315:
URL: https://github.com/apache/arrow/pull/8315#discussion_r499956145
##########
File path: dev/tasks/python-wheels/osx-build.sh
##########
@@ -67,6 +67,7 @@ function build_wheel {
-DARROW_GANDIVA=OFF \
-DARROW_GRPC_USE_SHARED=OFF \
-DARROW_HDFS=ON \
+ -DARROW_S3=${ARROW_S3} \
Review comment:
Could you keep alphabetical order?
##########
File path: dev/tasks/python-wheels/osx-build.sh
##########
@@ -103,6 +104,7 @@ function build_wheel {
export PYARROW_WITH_DATASET=1
export PYARROW_WITH_FLIGHT=1
export PYARROW_WITH_HDFS=1
+ export PYARROW_WITH_S3=${ARROW_S3}
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org