You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/03 16:07:32 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #3213: Flink: auto compact small files and expire snapshots

rdblue commented on a change in pull request #3213:
URL: https://github.com/apache/iceberg/pull/3213#discussion_r720849912



##########
File path: core/src/main/java/org/apache/iceberg/BaseRowDelta.java
##########
@@ -104,6 +106,17 @@ public RowDelta validateNoConflictingDeleteFiles() {
 
   @Override
   protected void validate(TableMetadata base) {
+    // update startingSnapshotId.

Review comment:
       Changing the starting snapshot ID breaks the correctness of certain operations, so I don't think that's what you want to do. What are you trying to do here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org