You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <st...@gmx.ch> on 2007/08/24 21:36:58 UTC
Re: svn commit: r26294 - trunk/subversion/libsvn_ra_serf
lgo@tigris.org wrote:
> + if (!baseline_url)
> + {
> + abort();
> + }
Please do not call abort()! Return an error instead!
http://subversion.tigris.org/issues/show_bug.cgi?id=2780
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26294 - trunk/subversion/libsvn_ra_serf
Posted by Stefan Küng <st...@gmx.ch>.
Lieven Govaerts wrote:
> Stefan Küng wrote:
>> lgo@tigris.org wrote:
>>> + if (!baseline_url)
>>> + {
>>> + abort();
>>> + }
>> Please do not call abort()! Return an error instead!
>> http://subversion.tigris.org/issues/show_bug.cgi?id=2780
> The abort() was already there, it just moved.
>
> But thanks for the reminder anyway. Once I get ra_serf pass all tests
> (only 3 to go) I'll try to get rid of those aborts.
Sorry, didn't realize that this was only moved, not new.
And thanks for trying to get rid of those, I'll really appreciate it if
those are finally gone.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26294 - trunk/subversion/libsvn_ra_serf
Posted by Lieven Govaerts <sv...@mobsol.be>.
Stefan Küng wrote:
> lgo@tigris.org wrote:
>> + if (!baseline_url)
>> + {
>> + abort();
>> + }
>
> Please do not call abort()! Return an error instead!
> http://subversion.tigris.org/issues/show_bug.cgi?id=2780
The abort() was already there, it just moved.
But thanks for the reminder anyway. Once I get ra_serf pass all tests
(only 3 to go) I'll try to get rid of those aborts.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org