[jira] Resolved: (MYFACES-2350) All renderers of components that implements ClientBehaviorHolder should encode javascript attributes

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2350.
-------------------------------------

    Fix Version/s: 2.0.1-SNAPSHOT
       Resolution: Fixed

I did a review and everything is in place. I added some missing calls to HtmlRendererUtils.decodeClientBehaviors(context, component), so we can close this issue.

> All renderers of components that implements ClientBehaviorHolder should encode javascript attributes
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2350
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2350
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.1-SNAPSHOT
>
>         Attachments: MYFACES-2350-1.patch
>
>
> All components in javax.faces.component package implements ClientBehaviorHolder, and has properties used to render javascript.
> Right now, f:ajax tag handler implementation attach AjaxBehavior instances, but it is responsibility of the renderer to retrieve it and render it properly.
> This part is necessary to make f:ajax tag handler work (because this part shows the results!)
> There are two properties that needs special attention, because it collision with properties:
> clientEvent                property                                  html javascript            in
> -------------------------------------------------------------------------------------------------------------
> valueChange            valueChangeListener         onchange                   UIInput
> action                         actionExpression                 onclick                        UICommand
> The interfaces _ChangeSelectProperties, _EventProperties, _FocusBlurProperties define javascript properties. Also, the class _HtmlBody has onload and onunload.
> We need to change all renderers to deal with this, taking into account the previous information.
> Also, it is necessary to add a call to Behavior.broadcast in UIComponentBase.broadcast, as described on its javadoc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.