You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thiruvel Thirumoolan <th...@yahoo-inc.com> on 2015/02/18 07:58:53 UTC
Review Request 31152: HIVE-9582: HCatalog should use IMetaStoreClient
interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31152/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-9582: HCatalog should use IMetaStoreClient interface
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06
hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145
hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 8c4bca02abeda7eb89ea0deacdfb2e06c9fda7f8
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0
hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 0aa0f515d9d15d442d31e32a63586d119c30494e
Diff: https://reviews.apache.org/r/31152/diff/
Testing
-------
All hcatalog unit tests pass.
Thanks,
Thiruvel Thirumoolan
Re: Review Request 31152: HIVE-9582: HCatalog should use
IMetaStoreClient interface
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
> On Feb. 26, 2015, 10:12 p.m., Thejas Nair wrote:
> > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java, line 176
> > <https://reviews.apache.org/r/31152/diff/1/?file=867387#file867387line176>
> >
> > shouldn't this be client.getDelegationToken(c.getUser(), u) ?
Thanks Thejas, I will check on the first set of comments and update the patch.
- Thiruvel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31152/#review74374
-----------------------------------------------------------
On Feb. 18, 2015, 6:58 a.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31152/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 6:58 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9582: HCatalog should use IMetaStoreClient interface
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145
> hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 8c4bca02abeda7eb89ea0deacdfb2e06c9fda7f8
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0
> hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 0aa0f515d9d15d442d31e32a63586d119c30494e
>
> Diff: https://reviews.apache.org/r/31152/diff/
>
>
> Testing
> -------
>
> All hcatalog unit tests pass.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>
Re: Review Request 31152: HIVE-9582: HCatalog should use
IMetaStoreClient interface
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31152/#review74374
-----------------------------------------------------------
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
<https://reviews.apache.org/r/31152/#comment120940>
Its better to include the actual error message in the exception. That way user does not need to go find it from the stack trace.
ie
Error connecting to Hive Metastore URI: "
+ endPoint.metaStoreUri + ": " + e.getMessage, e);
hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java
<https://reviews.apache.org/r/31152/#comment120942>
same comment as above, can you please + e.getMessage() .
( i know you are following the pattern followed currently in the above catch)
hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java
<https://reviews.apache.org/r/31152/#comment120943>
+ e.getMessage() .
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java
<https://reviews.apache.org/r/31152/#comment120937>
shouldn't this be client.getDelegationToken(c.getUser(), u) ?
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java
<https://reviews.apache.org/r/31152/#comment120936>
shouldn't this be client.getDelegationToken(c.getUser(), u) ?
- Thejas Nair
On Feb. 18, 2015, 6:58 a.m., Thiruvel Thirumoolan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31152/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 6:58 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-9582: HCatalog should use IMetaStoreClient interface
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145
> hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 8c4bca02abeda7eb89ea0deacdfb2e06c9fda7f8
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0
> hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158
> hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 0aa0f515d9d15d442d31e32a63586d119c30494e
>
> Diff: https://reviews.apache.org/r/31152/diff/
>
>
> Testing
> -------
>
> All hcatalog unit tests pass.
>
>
> Thanks,
>
> Thiruvel Thirumoolan
>
>
Re: Review Request 31152: HIVE-9582: HCatalog should use
IMetaStoreClient interface
Posted by Thiruvel Thirumoolan <th...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31152/
-----------------------------------------------------------
(Updated March 4, 2015, 11:34 p.m.)
Review request for hive.
Changes
-------
Addressed review comments.
Repository: hive-git
Description
-------
HIVE-9582: HCatalog should use IMetaStoreClient interface
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 63909b893b4be32647a0d91e58bc0dca86bcabd9
hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java a001252faaf9949b6d2f0e3110c2b343b9648a91
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java cead40d6eb7df285987c92b58021246e888dc502
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java bf2ba5a1c9135bb99cb12b4111e60e2b0a2ea10f
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputFormatContainer.java 1cd5306aafb9b3ec61c31fb6504c8082b47ed2ae
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java 694739821a202780818924d54d10edb707cfbcfa
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/InitializeInput.java 1980ef50af42499e0fed8863b6ff7a45f926d9fc
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e4c3d521b310f9b2dc2f154ae5a555ab06
hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHiveClientCache.java 63a55482f7e9115f5626c5cde036597248459118
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestPassProperties.java f8a0af14e3d0b9dc5005f1c2f390f4e2dc054145
hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/PigHCatUtil.java 48a40b1c11d44c6d53d8f58b7ea91f090e72920f
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/AbstractRecordWriter.java 1c85ab5944628a388b4983a557600035d6d610b2
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java a08f2f97e4e297873250ac8d16c7679c2de901f0
hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java cd05254f4e138b7c1ec7d9424c90416b25f93462
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java 1b9663d2d0e2e0d94b520ed6760415be441c7ab4
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java 8ae61a1e330b56037dd7440fa888e431c65fc158
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonControllerJob.java 53eecfa990bcaab247ae8bc4df221742bd166081
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java b4bb67944713951f089a9b8c11485fbf46088b49
Diff: https://reviews.apache.org/r/31152/diff/
Testing
-------
All hcatalog unit tests pass.
Thanks,
Thiruvel Thirumoolan