You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/13 05:50:42 UTC
[GitHub] [apisix-dashboard] FangSen9000 opened a new pull request, #2472: Update deploy-with-docker.md
FangSen9000 opened a new pull request, #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [*] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
它解决了[doc]仪表板docker实现使用优化issues[#2446](https://github.com/apache/apisix-dashboard/issues/2446)：
apisix-dashboard登录成功，然后访问apisix/admin/labels/route或apisix/admin/labels/consumer，遇到401未经授权的错误代码，这意味着仪表板授权的jwt令牌无效。
最后在社区的帮助下，发现原因不止1个仪表盘实例。
使用多实例，每个实例生成并持有一个jwt令牌，将导致验证冲突
因此，我们可以优化文档以强调仪表板实例数量不超过1，这与apisix本身的高可用性不同。
我已经在 Docker 相关文档中的适当位置添加了注释。
**Related issues**
fix/resolve [doc] 仪表板 Docker 实现使用优化 issues[#2446](https://github.com/apache/apisix-dashboard/issues/2446)
**Checklist:**
- [*] Did you explain what problem does this PR solve? Or what new features have been added?
- [*] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [*] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2472: Update deploy-with-docker.md
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on code in PR #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472#discussion_r896339131
##########
docs/en/latest/deploy-with-docker.md:
##########
@@ -87,3 +87,5 @@ $ docker stop apisix-dashboard
```sh
$ docker build -t apisix-dashboard:$tag . --no-cache=true
```
+
+2. It is not recommended to use multiple instances at the same time. When using multiple instances, each instance generates and holds a JWT token, which will lead to verification conflicts.
Review Comment:
```suggestion
2. It is not recommended to use multiple instances at the same time. When using multiple instances, each instance generates and holds a JWT token, which will lead to verification conflicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2472: docs: update deploy-with-docker.md
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2472: Update deploy-with-docker.md
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on PR #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472#issuecomment-1154671692
Pls also revise the description of the PR in English to make it accurate and clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] FangSen9000 commented on pull request #2472: Update deploy-with-docker.md
Posted by GitBox <gi...@apache.org>.
FangSen9000 commented on PR #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472#issuecomment-1153510032
@Baoyuantop, I accidentally changed the file name before, but only changed the content this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2472: Update deploy-with-docker.md
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on code in PR #2472:
URL: https://github.com/apache/apisix-dashboard/pull/2472#discussion_r896339131
##########
docs/en/latest/deploy-with-docker.md:
##########
@@ -87,3 +87,5 @@ $ docker stop apisix-dashboard
```sh
$ docker build -t apisix-dashboard:$tag . --no-cache=true
```
+
+2. It is not recommended to use multiple instances at the same time. When using multiple instances, each instance generates and holds a JWT token, which will lead to verification conflicts.
Review Comment:
```suggestion
2. It is not recommended to use multiple instances at the same time. When using multiple instances, each instance generates and holds a JWT token, which will lead to verification conflicts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org