You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HxpSerein (via GitHub)" <gi...@apache.org> on 2024/11/11 10:42:20 UTC
[PR] [remove datanode] Log the node information when submitting RegionMigrateProcedure [iotdb]
HxpSerein opened a new pull request, #14051:
URL: https://github.com/apache/iotdb/pull/14051
## Description
Log specific node information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Log the node information when submitting RegionMigrateProcedure [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #14051:
URL: https://github.com/apache/iotdb/pull/14051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Log the node information when submitting RegionMigrateProcedure [iotdb]
Posted by "HxpSerein (via GitHub)" <gi...@apache.org>.
HxpSerein commented on code in PR #14051:
URL: https://github.com/apache/iotdb/pull/14051#discussion_r1836692522
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java:
##########
@@ -130,23 +130,40 @@ public void changeDataNodeStatus(
for (Map.Entry<Integer, TSStatus> entry :
changeDataNodeStatusContext.getResponseMap().entrySet()) {
- long currentTime = System.nanoTime();
-
int dataNodeId = entry.getKey();
NodeStatus nodeStatus = nodeStatusMap.get(dataNodeId);
RegionStatus regionStatus = RegionStatus.valueOf(nodeStatus.getStatus());
+
+ if (!isSucceed(entry.getValue())) {
+ LOGGER.error(
+ "{}, Failed to change DataNode status, dataNodeId={}, nodeStatus={}",
+ REMOVE_DATANODE_PROCESS,
+ dataNodeId,
+ nodeStatus);
+ continue;
+ }
+
// Force updating NodeStatus
+ long currentTime = System.nanoTime();
Review Comment:
`updateCurrentStatistics` will choose the latest sample, so I print the time here to compare with the sample in the updateCurrentStatistics to check if it is because of the race of normal hearbeat from DataNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Log the node information when submitting RegionMigrateProcedure [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #14051:
URL: https://github.com/apache/iotdb/pull/14051#discussion_r1836687142
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java:
##########
@@ -130,23 +130,40 @@ public void changeDataNodeStatus(
for (Map.Entry<Integer, TSStatus> entry :
changeDataNodeStatusContext.getResponseMap().entrySet()) {
- long currentTime = System.nanoTime();
-
int dataNodeId = entry.getKey();
NodeStatus nodeStatus = nodeStatusMap.get(dataNodeId);
RegionStatus regionStatus = RegionStatus.valueOf(nodeStatus.getStatus());
+
+ if (!isSucceed(entry.getValue())) {
+ LOGGER.error(
+ "{}, Failed to change DataNode status, dataNodeId={}, nodeStatus={}",
+ REMOVE_DATANODE_PROCESS,
+ dataNodeId,
+ nodeStatus);
+ continue;
+ }
+
// Force updating NodeStatus
+ long currentTime = System.nanoTime();
Review Comment:
print nanotime is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [remove datanode] Log the node information when submitting RegionMigrateProcedure [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #14051:
URL: https://github.com/apache/iotdb/pull/14051#discussion_r1836712051
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java:
##########
@@ -130,23 +130,40 @@ public void changeDataNodeStatus(
for (Map.Entry<Integer, TSStatus> entry :
changeDataNodeStatusContext.getResponseMap().entrySet()) {
- long currentTime = System.nanoTime();
-
int dataNodeId = entry.getKey();
NodeStatus nodeStatus = nodeStatusMap.get(dataNodeId);
RegionStatus regionStatus = RegionStatus.valueOf(nodeStatus.getStatus());
+
+ if (!isSucceed(entry.getValue())) {
+ LOGGER.error(
+ "{}, Failed to change DataNode status, dataNodeId={}, nodeStatus={}",
+ REMOVE_DATANODE_PROCESS,
+ dataNodeId,
+ nodeStatus);
+ continue;
+ }
+
// Force updating NodeStatus
+ long currentTime = System.nanoTime();
Review Comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org