You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by gs...@apache.org on 2012/03/22 22:31:09 UTC
svn commit: r1304079 -
/subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c
Author: gstein
Date: Thu Mar 22 21:31:09 2012
New Revision: 1304079
URL: http://svn.apache.org/viewvc?rev=1304079&view=rev
Log:
* subversion/libsvn_ra_serf/sb_bucket.c:
(svn_ra_serf__copy_into_spillbuf): switch from expedient/temporary
error handling to proper solution.
Modified:
subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c
Modified: subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c?rev=1304079&r1=1304078&r2=1304079&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/sb_bucket.c Thu Mar 22 21:31:09 2012
@@ -60,8 +60,8 @@ svn_ra_serf__copy_into_spillbuf(svn_spil
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
- /* ### we should throw an error, if the bucket does. */
- SVN_ERR_ASSERT(status == APR_SUCCESS || status == APR_EOF);
+ if (status != APR_SUCCESS && status != APR_EOF)
+ return svn_error_wrap_apr(status, "Failed to read the request");
SVN_ERR(svn_spillbuf__write(*spillbuf, data, len, scratch_pool));