[jira] [Commented] (LUCENE-5781) don't create unused states in LevenshteinAutomata

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039772#comment-14039772 ] 

Robert Muir commented on LUCENE-5781:
-------------------------------------

If this is committed, then the comments should be fixed to.

What are the concrete benefits? I think the laziness makes the code significantly harder to read: this is probably already our most complex code. Can we do it in a simpler way? If we must do it this way, can the method have proper docs (like all other methods in this class)?

> don't create unused states in LevenshteinAutomata
> -------------------------------------------------
>
>                 Key: LUCENE-5781
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5781
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5781.patch
>
>
> While working on LUCENE-5752 I discovered that LevenshteinAutomata creates unused states with cycles.  I think they are basically harmless but we still shouldn't create them?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org