You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/24 02:43:57 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

AngersZhuuuu commented on a change in pull request #34689:
URL: https://github.com/apache/spark/pull/34689#discussion_r755655665



##########
File path: hadoop-cloud/pom.xml
##########
@@ -201,7 +201,7 @@
      enables store-specific committers.
     -->
     <profile>
-      <id>hadoop-3.2</id>
+      <id>hadoop-3.3</id>

Review comment:
       > How about avoiding this going forward with `hadoop-3`? I doubt we're going to publish builds separately for two different Hadoop 3 versions in the future.
   
   You mean here we can make profile id as  `hadoop-3`, then we can build spark release with `-Dhadoop.version=3.2.x` and `-Dhadoop.version=3.3.x`?
   
   I think it's ok if we need to maintain two version of hadoop3. Anyway better than `hadoop-3.2`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org