You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mikhail Loenko <ml...@gmail.com> on 2006/09/04 08:13:29 UTC
[classlib] internationalization and new patches
We have recently starting internationalization of existing modules
(thanks to all people involved!)
Now when we submit new patches and apply old ones let's make sure that
we don't break internationalization for the modules that were already
internationalized!
Thanks,
Mikhail
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] internationalization and new patches
Posted by Ilya Okomin <il...@gmail.com>.
On 9/6/06, Paulex Yang <pa...@gmail.com> wrote:
>
> Ilya Okomin wrote:
> > When I dealt with nio_char module I found that some messages were
> already
> > marked with non-nls tag.
> > (e.g. java.nio.charset.CharsetDecoder)
> > These messages aren't described in the spec.
> > Is there any reason to left them as is without internationalization?
> Specific to CharsetDecoder.replaceWith(), I don't believe there is any
> reason not to i18n the exception messages, I guess it was marked
> "non-nls" by mistake, or just because the developer didn't like to see
> the warning message;-). Please go ahead and provide patch for it.
I have the same meaning and going to make an update patch for these
messages.
Thanks,
Ilya.
>
> > Thanks,
> > Ilya.
> >
> > [SNIP]
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
--
Ilya Okomin
Intel Middleware Products Division
Re: [classlib] internationalization and new patches
Posted by Paulex Yang <pa...@gmail.com>.
Ilya Okomin wrote:
> When I dealt with nio_char module I found that some messages were already
> marked with non-nls tag.
> (e.g. java.nio.charset.CharsetDecoder)
> These messages aren't described in the spec.
> Is there any reason to left them as is without internationalization?
Specific to CharsetDecoder.replaceWith(), I don't believe there is any
reason not to i18n the exception messages, I guess it was marked
"non-nls" by mistake, or just because the developer didn't like to see
the warning message;-). Please go ahead and provide patch for it.
>
> Thanks,
> Ilya.
>
> [SNIP]
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] internationalization and new patches
Posted by Ilya Okomin <il...@gmail.com>.
When I dealt with nio_char module I found that some messages were already
marked with non-nls tag.
(e.g. java.nio.charset.CharsetDecoder)
These messages aren't described in the spec.
Is there any reason to left them as is without internationalization?
Thanks,
Ilya.
On 9/4/06, Ilya Okomin <il...@gmail.com> wrote:
>
>
>
> On 9/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> >
> > We have recently starting internationalization of existing modules
> > (thanks to all people involved!)
> >
> > Now when we submit new patches and apply old ones let's make sure that
> > we don't break internationalization for the modules that were already
> > internationalized!
>
>
> I've analyzed modules in Harmony that were already internationalized,
> they are: luni, archive, sql.
> IMHO we must don't break internationalization for the modules that were
> already
> internationalized but we should update them to follow the
> new internationalization scheme that was discussed on harmony-dev. This
> scheme supposed to be common for all modules in harmony.
>
> Turning back to already internationalized modules..
> There is nothing to do for sql module.
> Archive module was partly internationalized. I've prepared patch where all
> necessary messages were ported from the
> o.a.h.luni.util.ExternalMessages.properties file into the
> o.a.h.archive.internal.nls.messages.properties file with updated keys.
> Committer who is going to apply this patch or any other patch with
> internationalization for this module - should check if everything is
> correct.
> I suggest to do the same with luni module.
>
> Regards,
> Ilya.
>
>
> Thanks,
> > Mikhail
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
>
> --
> Ilya Okomin
> Intel Middleware Products Division
>
--
--
Ilya Okomin
Intel Middleware Products Division
Re: [classlib] internationalization and new patches
Posted by Ilya Okomin <il...@gmail.com>.
On 9/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
>
> We have recently starting internationalization of existing modules
> (thanks to all people involved!)
>
> Now when we submit new patches and apply old ones let's make sure that
> we don't break internationalization for the modules that were already
> internationalized!
I've analyzed modules in Harmony that were already internationalized, they
are: luni, archive, sql.
IMHO we must don't break internationalization for the modules that were
already
internationalized but we should update them to follow the
new internationalization scheme that was discussed on harmony-dev. This
scheme supposed to be common for all modules in harmony.
Turning back to already internationalized modules..
There is nothing to do for sql module.
Archive module was partly internationalized. I've prepared patch where all
necessary messages were ported from the
o.a.h.luni.util.ExternalMessages.properties file into the
o.a.h.archive.internal.nls.messages.properties file with updated keys.
Committer who is going to apply this patch or any other patch with
internationalization for this module - should check if everything is
correct.
I suggest to do the same with luni module.
Regards,
Ilya.
Thanks,
> Mikhail
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
--
Ilya Okomin
Intel Middleware Products Division