You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/05 11:03:56 UTC

[GitHub] [kafka] vitojeng opened a new pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

vitojeng opened a new pull request #10825:
URL: https://github.com/apache/kafka/pull/10825


   follow-up #8200
   
   KAFKA-5876's PR break into multiple parts, this PR is part 5.
   
   In KIP-216, the following exceptions is currently not completed: StreamsRebalancingException, StreamsRebalancingException, StateStoreNotAvailableException. In the CompositeReadOnlyXXXXStore class, we need using streams state to decide which exception should be throw.
   
   This PR add a new method `streams()` to StateStoreProvider interface, so that we can get streams state in the CompositeReadOnlyXXXXStore class to decide which exception should be throw.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-855223713


   @ableegoldman Please take a look :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554


   Hey @ableegoldman, just a remind. Please take a look, when you have time. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng edited a comment on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng edited a comment on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-866794585


   update PR & rebase trunk.
   Remove:
   ```
   KafkaStreams streams();
   ```
   Add 
   ```
   KafkaStreams.State streamsState();
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-866504180


   > Just one high-level comment: if all we need this for is the state, then maybe we should just add a method for that instead of exposing the `KafkaStreams` object directly. Not that it really matters that much, but it's the "safe" thing to do to limit the access to only what's necessary.
   > 
   > Thoughts?
   
   Agree, thanks for the suggestion. 
   Will update the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554


   Hey @ableegoldman, just a remind. Please take a look, when you have time. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10825:
URL: https://github.com/apache/kafka/pull/10825#issuecomment-866794585


   update PR & rebase trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org