You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jason Altekruse <al...@gmail.com> on 2015/07/08 07:44:08 UTC

Review Request 36292: DRILL-2838: flatten after join failing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36292/
-----------------------------------------------------------

Review request for drill and Hanifi Gunes.


Bugs: DRILL-2838
    https://issues.apache.org/jira/browse/DRILL-2838


Repository: drill-git


Description
-------

This issue was fixed for project recently, it relates to imcomplete schema population. I applied the same fix to the flatten operator. I tried to get some intial work done on refactoring to more appropriately share code between flatten and project. This is a bit large in scope, so I have added a new JIRA to track this https://issues.apache.org/jira/browse/DRILL-3471


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 491ced3 
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java 39e36eb 
  exec/java-exec/src/test/resources/flatten/complex_transaction_example_data_modified.json PRE-CREATION 
  exec/java-exec/src/test/resources/flatten/complex_transaction_repeated_map_double_copy_baseline.json PRE-CREATION 

Diff: https://reviews.apache.org/r/36292/diff/


Testing
-------

Testing in progress, relevent related unit tests are passing


Thanks,

Jason Altekruse


Re: Review Request 36292: DRILL-2838: flatten after join failing

Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36292/#review91027
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java (line 65)
<https://reviews.apache.org/r/36292/#comment144255>

    I am not sure how different flatten is planned as it is a UDF looking operator. However, should we not flatten the same field at least twice to test this patch?


- Hanifi Gunes


On July 8, 2015, 5:44 a.m., Jason Altekruse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36292/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 5:44 a.m.)
> 
> 
> Review request for drill and Hanifi Gunes.
> 
> 
> Bugs: DRILL-2838
>     https://issues.apache.org/jira/browse/DRILL-2838
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> This issue was fixed for project recently, it relates to imcomplete schema population. I applied the same fix to the flatten operator. I tried to get some intial work done on refactoring to more appropriately share code between flatten and project. This is a bit large in scope, so I have added a new JIRA to track this https://issues.apache.org/jira/browse/DRILL-3471
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 491ced3 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/flatten/TestFlatten.java 39e36eb 
>   exec/java-exec/src/test/resources/flatten/complex_transaction_example_data_modified.json PRE-CREATION 
>   exec/java-exec/src/test/resources/flatten/complex_transaction_repeated_map_double_copy_baseline.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36292/diff/
> 
> 
> Testing
> -------
> 
> Testing in progress, relevent related unit tests are passing
> 
> 
> Thanks,
> 
> Jason Altekruse
> 
>