[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10267: fix: broken glyphicons used in react-json-schema

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10267:
URL: https://github.com/apache/incubator-superset/pull/10267#discussion_r454623379



##########
File path: superset/views/sql_lab.py
##########
@@ -162,6 +162,7 @@ class SavedQueryViewApi(SavedQueryView):  # pylint: disable=too-many-ancestors
         "description",
         "sql",
         "extra_json",
+        "extra",

Review comment:
       `extra_json` is a string containing the serialized JSON, `extra` is the actual nested data structure. While I know the private API does not use `extra_json`, I assume that people in the wild (notably at Lyft where @betodealmeida shipped the feature) are very likely to use it. 
   
   Clearly it's not great to have JSON inception (serialized JSON inside of JSON)
   
   I could have deprecated `extra_json` in favor of `extra`, but would need to do change management around it - likely just adding a note in `UPDATING.md`. Eventually we should move this under `/api/v1` but, maybe a good time to do this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org