You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/26 13:09:54 UTC
[GitHub] [kafka] jlprat opened a new pull request #10768: MINOR: fix code listings for ops
jlprat opened a new pull request #10768:
URL: https://github.com/apache/kafka/pull/10768
Fixes indentation, uses the right character for bash (`>`), and fixes
syntax highlighting for listings
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a change in pull request #10768: MINOR: fix code listings for ops.html
Posted by GitBox <gi...@apache.org>.
jlprat commented on a change in pull request #10768:
URL: https://github.com/apache/kafka/pull/10768#discussion_r640340174
##########
File path: docs/ops.html
##########
@@ -248,98 +248,98 @@ <h5 class="anchor-heading"><a id="basic_ops_automigrate" class="anchor-link"></a
For instance, the following example will move all partitions for topics foo1,foo2 to the new set of brokers 5,6. At the end of this move, all partitions for topics foo1 and foo2 will <i>only</i> exist on brokers 5,6.
<p>
Since the tool accepts the input list of topics as a json file, you first need to identify the topics you want to move and create the json file as follows:
- <pre class="line-numbers"><code class="language-bash"> > cat topics-to-move.json
- {"topics": [{"topic": "foo1"},
- {"topic": "foo2"}],
- "version":1
- }</code></pre>
+ <pre class="line-numbers"><code class="language-bash">> cat topics-to-move.json
Review comment:
Good catch! Pushed a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10768: MINOR: fix code listings for ops.html
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10768:
URL: https://github.com/apache/kafka/pull/10768#discussion_r640268231
##########
File path: docs/ops.html
##########
@@ -248,98 +248,98 @@ <h5 class="anchor-heading"><a id="basic_ops_automigrate" class="anchor-link"></a
For instance, the following example will move all partitions for topics foo1,foo2 to the new set of brokers 5,6. At the end of this move, all partitions for topics foo1 and foo2 will <i>only</i> exist on brokers 5,6.
<p>
Since the tool accepts the input list of topics as a json file, you first need to identify the topics you want to move and create the json file as follows:
- <pre class="line-numbers"><code class="language-bash"> > cat topics-to-move.json
- {"topics": [{"topic": "foo1"},
- {"topic": "foo2"}],
- "version":1
- }</code></pre>
+ <pre class="line-numbers"><code class="language-bash">> cat topics-to-move.json
Review comment:
Should we replace `>` into `>` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10768: MINOR: fix code listings for ops.html
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10768:
URL: https://github.com/apache/kafka/pull/10768#issuecomment-848762557
CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org