[GitHub] [flink] dannycranmer commented on a diff in pull request #21458: [FLINK-28513][hotfix] stream.sync is not supported for s3 fileformat

[GitBox <gi...@apache.org>]

dannycranmer commented on code in PR #21458:
URL: https://github.com/apache/flink/pull/21458#discussion_r1046891518


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -126,7 +126,9 @@ public long getPos() throws IOException {
 
     @Override
     public void sync() throws IOException {
-        fileStream.sync();
+        // for s3 there is no sync supported.
+        // instead calling persist() to put data into s3.
+        persist();
     }

Review Comment:
   It does not look like these are equivalent. It seems as though `.sync()` is blocking and `persist()` is async. Is there a way to way for persist to complete to retain the semantics here?
   
   Also, not tests failed or added for this change. Can we add a test please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org