[GitHub] [spark] advancedxy commented on a change in pull request #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration

[GitBox <gi...@apache.org>]

advancedxy commented on a change in pull request #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration
URL: https://github.com/apache/spark/pull/25002#discussion_r299781485
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/python/PythonHadoopUtil.scala
 ##########
 @@ -156,7 +156,7 @@ private[python] object PythonHadoopUtil {
    * Convert a [[java.util.Map]] of properties to a [[org.apache.hadoop.conf.Configuration]]
    */
   def mapToConf(map: java.util.Map[String, String]): Configuration = {
-    val conf = new Configuration()
+    val conf = new Configuration(false)
 
 Review comment:
   Internally this is only called in PythonRDD and I have replaced all the invocations with merged SparkContext's hadoop conf. So it shouldn't break things in spark side. I ran the UTs of Scala side, haven't run python unit tests though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org