You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/01 00:04:14 UTC

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10206: build: enable Cypress tests for visualizations

etr2460 commented on a change in pull request #10206:
URL: https://github.com/apache/incubator-superset/pull/10206#discussion_r448044372



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
##########
@@ -57,7 +57,10 @@ describe('Visualization > Bubble', () => {
     cy.route('POST', '/superset/explore_json/**').as('getJson');
   });
 
-  it('should work', () => {
+  // Number of circles are pretty unstable when there are a lot of circles
+  // Since main functionality is already covered in fitler test below,
+  // skip this test untill we find a solution.

Review comment:
       if this test is unstable and we already cover main functionality, should we delete the test? Seems like there's not much point in keeping it around tbh




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org