You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/22 08:49:15 UTC
[GitHub] [nifi] wangliqiangnewstart opened a new pull request #5176: claimantCount will never decrement to zero bug fix
wangliqiangnewstart opened a new pull request #5176:
URL: https://github.com/apache/nifi/pull/5176
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
This is the probl
//originalFlowFile has content , so ClaimantCount=1
FlowFile multiFlowFile = session.clone(originalFlowFile); // claim count +1,so ClaimantCount=2
multiFlowFile = session.write(multiFlowFile, new OutputStreamCallback() {
@Override
public void process(OutputStream out) throws IOException {
IOUtils.write(tvMultiAlbumJson, out, Charset.forName("UTF-8"));
}
});//the new content will resuse the same resource claim , so ClaimantCount=3
//At this point we have two flowfile and two contentClaim ,and ClaimCount=3.
//When this two flowfiles dropped,the claimantCount should decrement to 0,however the result is ClaimantCount=1!
//If we use "sh nifi.sh diagnostics --verbose dump.log" to get a dump log,we will find some info like this “default/465/1623853427574-10705, Claimant Count = 1, In Use = true, Awaiting Destruction = false, References (0) = []”
//And the file “default/465/1623853427574-10705” will never be archived,and will never be destroyed,and the content_repository will use more storage than it configs.
The above is a sort of phenomenon. The reason is the code below:
//session.clone
public FlowFile clone(FlowFile example, final long offset, final long size) {
.....................................
final StandardRepositoryRecord record = new StandardRepositoryRecord(null); //here the originalFlowFileRecord of record is null
.....................................
return clone;
}
//session.commit
private void updateClaimCounts(final RepositoryRecord record) {
..........................................................
if (record.isContentModified()) {
decrementClaimCount(originalClaim); //here the originalClaim is null
}
}
Perhaps we should not use session.clone like that,but without official note it will sometimes happen to be used.
So i change "final StandardRepositoryRecord record = new StandardRepositoryRecord(null)" to "final StandardRepositoryRecord record = new StandardRepositoryRecord(null, currRec);"
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5176: NIFI-8727 & NIFI-8728 - claimantCount will never decrement to zero bug fix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #5176:
URL: https://github.com/apache/nifi/pull/5176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] wangliqiangnewstart commented on pull request #5176: claimantCount will never decrement to zero bug fix
Posted by GitBox <gi...@apache.org>.
wangliqiangnewstart commented on pull request #5176:
URL: https://github.com/apache/nifi/pull/5176#issuecomment-866593998
> Hi @wangliqiangnewstart - thanks for this contribution. Can you please file a JIRA for this change/bug fix? All the pull requests need to reference a JIRA number. https://issues.apache.org/jira/browse/NIFI
The issue is https://issues.apache.org/jira/browse/NIFI-8727
The sub issue is https://issues.apache.org/jira/browse/NIFI-8728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] wangliqiangnewstart commented on pull request #5176: claimantCount will never decrement to zero bug fix
Posted by GitBox <gi...@apache.org>.
wangliqiangnewstart commented on pull request #5176:
URL: https://github.com/apache/nifi/pull/5176#issuecomment-865846367
sure
------------------ 原始邮件 ------------------
发件人: "Pierre ***@***.***>;
发送时间: 2021年6月22日(星期二) 下午5:59
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [apache/nifi] claimantCount will never decrement to zero bug fix (#5176)
Hi @wangliqiangnewstart - thanks for this contribution. Can you please file a JIRA for this change/bug fix? All the pull requests need to reference a JIRA number. https://issues.apache.org/jira/browse/NIFI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #5176: NIFI-8727 & NIFI-8728 - claimantCount will never decrement to zero bug fix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5176:
URL: https://github.com/apache/nifi/pull/5176#issuecomment-949091398
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #5176: claimantCount will never decrement to zero bug fix
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5176:
URL: https://github.com/apache/nifi/pull/5176#issuecomment-865844572
Hi @wangliqiangnewstart - thanks for this contribution. Can you please file a JIRA for this change/bug fix? All the pull requests need to reference a JIRA number. https://issues.apache.org/jira/browse/NIFI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org