You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/19 11:56:12 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
pandaapo opened a new pull request, #3981:
URL: https://github.com/apache/eventmesh/pull/3981
Fixes #3978.
### Motivation
org.apache.eventmesh.admin.rocketmq.request.TopicCreateRequest
* The field name is the same with `@JsonProperty`'s value.
* `super()` in this constructor will be invoked by default.
* Unit test case is not yet done.
### Modifications
* Remove `@JsonProperty`.
* Remove `super()`.
* Add unit test case.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on a diff in pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#discussion_r1209635305
##########
eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/request/TopicCreateRequest.java:
##########
@@ -30,16 +30,13 @@ public class TopicCreateRequest {
@JsonCreator
public TopicCreateRequest(@JsonProperty("name") String topic) {
- super();
this.name = topic;
Review Comment:
change the `name` to `topic` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on a diff in pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#discussion_r1206469976
##########
eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/request/TopicCreateRequest.java:
##########
@@ -30,16 +30,13 @@ public class TopicCreateRequest {
@JsonCreator
public TopicCreateRequest(@JsonProperty("name") String topic) {
- super();
this.name = topic;
Review Comment:
I'm not sure. Maybe the author plan to add more fields to this class in the future.
Will it be more readable than now when more fields are added to this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#issuecomment-1562190471
@pandaapo please fix the ci check error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#issuecomment-1562210768
> @pandaapo please fix the ci check error.
OK now. I will check all my other PRs and fix if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#issuecomment-1562407465
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3981](https://app.codecov.io/gh/apache/eventmesh/pull/3981?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5da988e) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ce8d57) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5da988e differs from pull request most recent head 751e4fe. Consider uploading reports for the commit 751e4fe to get more accurate results
```diff
@@ Coverage Diff @@
## master #3981 +/- ##
============================================
+ Coverage 14.24% 14.25% +0.01%
- Complexity 1320 1323 +3
============================================
Files 579 579
Lines 28967 28960 -7
Branches 2802 2788 -14
============================================
+ Hits 4125 4127 +2
+ Misses 24450 24442 -8
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3981?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...esh/admin/rocketmq/request/TopicCreateRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3981?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWFkbWluL2V2ZW50bWVzaC1hZG1pbi1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2FkbWluL3JvY2tldG1xL3JlcXVlc3QvVG9waWNDcmVhdGVSZXF1ZXN0LmphdmE=) | `100.00% <ø> (+100.00%)` | :arrow_up: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3981/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] lrhkobe commented on a diff in pull request #3981: [ISSUE #3978]Remove unnecessary annotations in TopicCreateRequest and add unit test.
Posted by "lrhkobe (via GitHub)" <gi...@apache.org>.
lrhkobe commented on code in PR #3981:
URL: https://github.com/apache/eventmesh/pull/3981#discussion_r1206444655
##########
eventmesh-admin/eventmesh-admin-rocketmq/src/main/java/org/apache/eventmesh/admin/rocketmq/request/TopicCreateRequest.java:
##########
@@ -30,16 +30,13 @@ public class TopicCreateRequest {
@JsonCreator
public TopicCreateRequest(@JsonProperty("name") String topic) {
- super();
this.name = topic;
Review Comment:
Maybe, using the same variable name for topic and name would improve readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org