You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2006/08/31 13:54:22 UTC

[jira] Created: (HARMONY-1361) [luni] more failproof SUID calculation

[luni] more failproof SUID calculation
--------------------------------------

                 Key: HARMONY-1361
                 URL: http://issues.apache.org/jira/browse/HARMONY-1361
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Alexey Varlamov
            Priority: Minor


The SUID calculation depends on poorly documented getSignature() method of kernel reflection classes, and may be vulnerable to subtle changes in value those methods return like using '.' vs '/' separators. Moreover, there are different separators expected for signatures of fields and ones of methods.
I was just playing with DRLVM kernel classes optimizations and unexpectedly hit the issue of incompartible SUIDs. 
So I suggest to add failproof formatting of method's signatures (it is already there for fields).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1361) [luni] more failproof SUID calculation

Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1361?page=all ]

Geir Magnusson Jr reassigned HARMONY-1361:
------------------------------------------

    Assignee: Geir Magnusson Jr

> [luni] more failproof SUID calculation
> --------------------------------------
>
>                 Key: HARMONY-1361
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1361
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexey Varlamov
>         Assigned To: Geir Magnusson Jr
>            Priority: Minor
>         Attachments: suid-fix.patch
>
>
> The SUID calculation depends on poorly documented getSignature() method of kernel reflection classes, and may be vulnerable to subtle changes in value those methods return like using '.' vs '/' separators. Moreover, there are different separators expected for signatures of fields and ones of methods.
> I was just playing with DRLVM kernel classes optimizations and unexpectedly hit the issue of incompartible SUIDs. 
> So I suggest to add failproof formatting of method's signatures (it is already there for fields).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1361) [luni] more failproof SUID calculation

Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1361?page=all ]

Alexey Varlamov updated HARMONY-1361:
-------------------------------------

    Attachment: suid-fix.patch

> [luni] more failproof SUID calculation
> --------------------------------------
>
>                 Key: HARMONY-1361
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1361
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexey Varlamov
>            Priority: Minor
>         Attachments: suid-fix.patch
>
>
> The SUID calculation depends on poorly documented getSignature() method of kernel reflection classes, and may be vulnerable to subtle changes in value those methods return like using '.' vs '/' separators. Moreover, there are different separators expected for signatures of fields and ones of methods.
> I was just playing with DRLVM kernel classes optimizations and unexpectedly hit the issue of incompartible SUIDs. 
> So I suggest to add failproof formatting of method's signatures (it is already there for fields).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-1361) [luni] more failproof SUID calculation

Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1361?page=all ]

Geir Magnusson Jr closed HARMONY-1361.
--------------------------------------

    Resolution: Fixed

fixed with HARMONY-1123 in r451082

> [luni] more failproof SUID calculation
> --------------------------------------
>
>                 Key: HARMONY-1361
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1361
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexey Varlamov
>         Assigned To: Geir Magnusson Jr
>            Priority: Minor
>         Attachments: suid-fix.patch
>
>
> The SUID calculation depends on poorly documented getSignature() method of kernel reflection classes, and may be vulnerable to subtle changes in value those methods return like using '.' vs '/' separators. Moreover, there are different separators expected for signatures of fields and ones of methods.
> I was just playing with DRLVM kernel classes optimizations and unexpectedly hit the issue of incompartible SUIDs. 
> So I suggest to add failproof formatting of method's signatures (it is already there for fields).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira