You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/22 08:20:16 UTC

[GitHub] [flink] xuyangzhong commented on a change in pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

xuyangzhong commented on a change in pull request #17546:
URL: https://github.com/apache/flink/pull/17546#discussion_r734333109



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/SqlExpressionTest.scala
##########
@@ -124,8 +124,8 @@ class SqlExpressionTest extends ExpressionTestBase {
     testSqlApi("ROUND(-12.345, 2)", "-12.35")
     testSqlApi("PI()", "3.141592653589793")
     testSqlApi("E()", "2.718281828459045")
-    testSqlApi("truncate(42.345)", "42")
-    testSqlApi("truncate(cast(42.345 as decimal(5, 3)), 2)", "42.34")
+    testSqlApi("truncate(42.345)", "42.000")

Review comment:
       When the rule PROJECT_REDUCE_EXPRESSIONS is added into ExpressionTestBase, the bug [FLINK-23614] happens. And the bug is only fixed in 1.15. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org