You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 14:40:14 UTC

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

fgerlits opened a new pull request, #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392

   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r948039984


##########
extensions/script/python/PythonCreator.h:
##########
@@ -129,7 +129,8 @@ class PythonCreator : public minifi::core::CoreComponent {
       return "";
     }
     const auto python_package_path = std::filesystem::relative(pythonscript, basePath).parent_path();
-    std::vector<std::string> path_elements{python_package_path.begin(), python_package_path.end()};
+    std::vector<std::string> path_elements;
+    std::transform(python_package_path.begin(), python_package_path.end(), std::back_inserter(path_elements), [](const auto& path) { return path.string(); });

Review Comment:
   ```suggestion
       std::vector<std::string> path_elements;
       path_elements.reserve(std::distance(python_package_path.begin(), python_package_path.end()));
       std::transform(python_package_path.begin(), python_package_path.end(), std::back_inserter(path_elements), [](const auto& path) { return path.string(); });
   ```



##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
 #ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 #define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 
+#undef COMPILER
+

Review Comment:
   Why is this needed? Could you add a comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r949338163


##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
 #ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 #define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 
+#undef COMPILER
+

Review Comment:
   I have found the culprit (it's https://github.com/python/cpython/blob/3.10/PC/pyconfig.h) and added a comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r949350744


##########
extensions/script/python/PythonCreator.h:
##########
@@ -129,7 +129,8 @@ class PythonCreator : public minifi::core::CoreComponent {
       return "";
     }
     const auto python_package_path = std::filesystem::relative(pythonscript, basePath).parent_path();
-    std::vector<std::string> path_elements{python_package_path.begin(), python_package_path.end()};
+    std::vector<std::string> path_elements;
+    std::transform(python_package_path.begin(), python_package_path.end(), std::back_inserter(path_elements), [](const auto& path) { return path.string(); });

Review Comment:
   done in ce7b901964cb0c53365c40ba7d5f00fdd701665a



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
lordgamez commented on PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#issuecomment-1222013325

   The MacOS I job failure looks to be connected to this change, could you check what caused that failure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r948082000


##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
 #ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 #define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 
+#undef COMPILER
+

Review Comment:
   TBH, I don't know why it's needed.  Something somewhere `#define`s `COMPILER` to the MSVC version, but I couldn't find what and where.
   
   I'll take another look and add the comment if I find out, but I didn't think `// something somewhere #defines COMPILE to the MSVC version on Windows` would be a useful comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r949046247


##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
 #ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 #define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 
+#undef COMPILER
+

Review Comment:
   That's fine, thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org