[GitHub] [spark] dilipbiswal edited a comment on issue #24652: [SPARK-27782][SQL] Use '#' to mark expression id embedded in the name field of SubqueryExec operator

[GitBox <gi...@apache.org>]

dilipbiswal edited a comment on issue #24652: [SPARK-27782][SQL] Use '#' to mark expression id embedded in the name field of SubqueryExec operator
URL: https://github.com/apache/spark/pull/24652#issuecomment-495971575
 
 
   @dongjoon-hyun 
   > As you needed to add a workaround, it seems that SQLQueryTestSuite is not designed to serve well this kind of use case. Please move this test coverage from scalar-subquery-predicate.sql to another test suite.
   
   Actually i am working on the new explain item and would like to test the new format out by using the SQLQueryTestSuite framework as much as possible as there would be so many combinations of plans. I was thinking to improve SQLQueryTestSuite to introduce a new list/map to have a list of test cases per codegen config or something in that direction. Or may be have 2 output files one for codegen on and one for codegen off. Please let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org